Cont remove legacy string calls

Author: tolyo

src/animations/animate-js.js

@@ -61,7 +61,7 @@ export function AnimateJsProvider($animateProvider) {
             beforeFn = "leave";
             afterFn = "afterLeave"; // TODO(matsko): get rid of this
           } else {
-            beforeFn = `before${event.charAt(0).toUpperCase()}${event.substr(1)}`;
+            beforeFn = `before${event.charAt(0).toUpperCase()}${event.substring(1)}`;
             afterFn = event;
           }
 

src/animations/animate.js

@@ -118,7 +118,7 @@ export function AnimateProvider($provide) {
     }
 
     const key = `${name}-animation`;
-    provider.$$registeredAnimations[name.substr(1)] = key;
+    provider.$$registeredAnimations[name.substring(1)] = key;
     $provide.factory(key, factory);
   };
 

src/core/cookie-reader.spec.js

@@ -13,7 +13,7 @@ describe("$$cookieReader", () => {
       for (let i = 0; i < cookies.length; i++) {
         const cookie = cookies[i];
         const eqPos = cookie.indexOf("=");
-        const name = eqPos > -1 ? cookie.substr(0, eqPos) : cookie;
+        const name = eqPos > -1 ? cookie.substring(0, eqPos) : cookie;
         const parts = path.split("/");
         while (parts.length) {
           document.cookie = `${name}=;path=${parts.join("/") || "/"};expires=Thu, 01 Jan 1970 00:00:00 GMT`;

src/core/location/location.js

@@ -389,7 +389,7 @@ export class LocationHtml5Url extends Location {
   }
 
   $$normalizeUrl(url) {
-    return this.appBaseNoFile + url.substr(1); // first char is always '/'
+    return this.appBaseNoFile + url.substring(1); // first char is always '/'
   }
 
   /**
@@ -926,17 +926,17 @@ function startsWith(str, search) {
  */
 export function stripBaseUrl(base, url) {
   if (startsWith(url, base)) {
-    return url.substr(base.length);
+    return url.substring(base.length);
   }
 }
 
 export function stripHash(url) {
   const index = url.indexOf("#");
-  return index === -1 ? url : url.substr(0, index);
+  return index === -1 ? url : url.substring(0, index);
 }
 
 export function stripFile(url) {
-  return url.substr(0, stripHash(url).lastIndexOf("/") + 1);
+  return url.substring(0, stripHash(url).lastIndexOf("/") + 1);
 }
 
 /* return the server only (scheme://host:port) */

src/core/parse/parse.spec.js

@@ -688,7 +688,7 @@ describe("parser", () => {
         scope.zero = 0;
         scope.bool = false;
 
-        expect(scope.$eval("empty.substr(0)")).toBe("");
+        expect(scope.$eval("empty.substring(0)")).toBe("");
         expect(scope.$eval("zero.toString()")).toBe("0");
         expect(scope.$eval("bool.toString()")).toBe("false");
       });

src/directive/model/model.spec.js

@@ -1265,7 +1265,7 @@ describe("ngModel", () => {
 
       it("should always use the most recent $viewValue for validation", () => {
         ctrl.$parsers.push((value) => {
-          if (value && value.substr(-1) === "b") {
+          if (value && value.slice(-1) === "b") {
             value = "a";
             ctrl.$setViewValue(value);
             ctrl.$render();
@@ -1288,14 +1288,14 @@ describe("ngModel", () => {
 
       it("should validate even if the modelValue did not change", () => {
         ctrl.$parsers.push((value) => {
-          if (value && value.substr(-1) === "b") {
+          if (value && value.slice(-1) === "b") {
             value = "a";
           }
 
           return value;
         });
 
-        ctrl.$validators.mock = function (modelValue) {
+        ctrl.$validators.mock = function () {
           return true;
         };
 

src/router/params/param-type.js

@@ -51,7 +51,7 @@ export class ParamType {
   }
   $subPattern() {
     const sub = this.pattern.toString();
-    return sub.substr(1, sub.length - 2);
+    return sub.substring(1, sub.length - 2);
   }
   toString() {
     return `{ParamType:${this.name}}`;

src/router/state/views.js

@@ -177,7 +177,7 @@ export class Ng1ViewConfig {
       ngViewName = relativeViewNameSugar[2]; // set view-name to "foo.bar"
     }
     if (ngViewName.charAt(0) === "!") {
-      ngViewName = ngViewName.substr(1);
+      ngViewName = ngViewName.substring(1);
       ngViewContextAnchor = ""; // target absolutely from root
     }
     // handle parent relative targeting "^.^.^"

src/shared/strings.js

@@ -20,7 +20,7 @@ import { pattern, val } from "./hof";
  */
 export function maxLength(max, str) {
   if (str.length <= max) return str;
-  return str.substr(0, max - 3) + "...";
+  return str.substring(0, max - 3) + "...";
 }
 /**
  * Returns a string, with spaces added to the end, up to a desired str length
@@ -46,7 +46,7 @@ export function functionToString(fn) {
   const toStr = namedFunctionMatch ? namedFunctionMatch[1] : fnStr;
   const fnName = fn["name"] || "";
   if (fnName && toStr.match(/function \(/)) {
-    return "function " + fnName + toStr.substr(9);
+    return "function " + fnName + toStr.substring(9);
   }
   return toStr;
 }
@@ -97,7 +97,7 @@ export const beforeAfterSubstr = (char) => (str) => {
   if (!str) return ["", ""];
   const idx = str.indexOf(char);
   if (idx === -1) return [str, ""];
-  return [str.substr(0, idx), str.substr(idx + 1)];
+  return [str.substring(0, idx), str.substring(idx + 1)];
 };
 export const hostRegex = new RegExp("^(?:[a-z]+:)?//[^/]+/");
 export const stripLastPathElement = (str) => str.replace(/\/[^/]*$/, "");