Type improvements on animate

Author: tolyo

.husky/pre-commit

@@ -1,5 +1,2 @@
-make lint
-make check
-make types
-make pretty
+
 git add ./

@types/animations/animate.d.ts

@@ -5,8 +5,8 @@ export class AnimationProvider {
     | string
     | ((
         $rootScope: ng.RootScopeService,
-        $injector: any,
-        $$rAFScheduler: any,
+        $injector: ng.InjectorService,
+        $$rAFScheduler: import("./raf-scheduler.js").RafScheduler,
         $$animateCache: any,
       ) => (element: any, event: any, options: any) => AnimateRunner)
   )[];

@types/animations/animation.d.ts

@@ -1,3 +1,5 @@
+import { AnimationOptions } from "./animate.js";
+import { AnimateRunner } from "./runner/animate-runner.js";
 export type RafScheduler = {
   /**
    * Schedules a list of functions to run on the next animation frame(s).
@@ -27,3 +29,59 @@ export interface AnimationHost {
   /** Report animation progress. */
   progress?: (...args: any[]) => void;
 }
+export interface AnimateService {
+  on(
+    event: string,
+    container: Element,
+    callback: (
+      element: Element,
+      phase: "start" | "close",
+      data: {
+        addClass: string | null;
+        removeClass: string | null;
+        from: Record<string, any> | null;
+        to: Record<string, any> | null;
+      },
+    ) => void,
+  ): void;
+  off(event: string, container?: Element, callback?: Function): void;
+  pin(element: Element, parentElement: Element): void;
+  enabled(element?: Element, enabled?: boolean): boolean;
+  cancel(runner: AnimateRunner): void;
+  enter(
+    element: Element,
+    parent: Element,
+    after?: Element,
+    options?: AnimationOptions,
+  ): AnimateRunner;
+  move(
+    element: Element,
+    parent: Element,
+    after?: Element,
+    options?: AnimationOptions,
+  ): AnimateRunner;
+  leave(element: Element, options?: AnimationOptions): AnimateRunner;
+  addClass(
+    element: Element,
+    className: string,
+    options?: AnimationOptions,
+  ): AnimateRunner;
+  removeClass(
+    element: Element,
+    className: string,
+    options?: AnimationOptions,
+  ): AnimateRunner;
+  setClass(
+    element: Element,
+    add: string,
+    remove: string,
+    options?: AnimationOptions,
+  ): AnimateRunner;
+  animate(
+    element: Element,
+    from: Record<string, any>,
+    to: Record<string, any>,
+    className?: string,
+    options?: AnimationOptions,
+  ): AnimateRunner;
+}

@types/animations/interface.d.ts

@@ -2,22 +2,22 @@ export class Attributes {
   static $nonscope: boolean;
   /**
    * @param {ng.RootScopeService} $rootScope
-   * @param {*} $animate
+   * @param {ng.AnimateService} $animate
    * @param {ng.ExceptionHandlerService} $exceptionHandler
    * @param {*} $sce
    * @param {import("../../shared/noderef.js").NodeRef} [nodeRef]
    * @param {Object} [attributesToCopy]
    */
   constructor(
     $rootScope: ng.RootScopeService,
-    $animate: any,
+    $animate: ng.AnimateService,
     $exceptionHandler: ng.ExceptionHandlerService,
     $sce: any,
     nodeRef?: import("../../shared/noderef.js").NodeRef,
     attributesToCopy?: any,
   );
   $rootScope: import("../scope/scope.js").Scope;
-  $animate: any;
+  $animate: import("../../interface.ts").AnimateService;
   $exceptionHandler: import("../../services/exception/interface.ts").ErrorHandler;
   $sce: any;
   $attr: {};

@types/core/compile/attributes.d.ts

@@ -124,15 +124,15 @@ export class CompileProvider {
   $get: (
     | string
     | ((
-        $injector: import("../../core/di/internal-injector.js").InjectorService,
+        $injector: ng.InjectorService,
         $interpolate: any,
         $exceptionHandler: import("../../services/exception/exception-handler.js").ErrorHandler,
-        $templateRequest: any,
-        $parse: import("../parse/interface.ts").ParseService,
+        $templateRequest: ng.TemplateRequestService,
+        $parse: ng.ParseService,
         $controller: any,
         $rootScope: import("../scope/scope.js").Scope,
         $sce: any,
-        $animate: any,
+        $animate: ng.AnimateService,
       ) => (
         compileNode: string | Element | Node | ChildNode | NodeList,
         transcludeFn?: import("./inteface.ts").TranscludeFn,

@types/core/compile/compile.d.ts

@@ -75,16 +75,16 @@ export class FormController {
   static $inject: string[];
   /**
    * @param {Element} $element
-   * @param {import("../../core/compile/attributes.js").Attributes} $attrs
-   * @param {import("../../core/scope/scope.js").Scope} $scope
-   * @param {*} $animate
+   * @param {ng.Attributes} $attrs
+   * @param {ng.Scope} $scope
+   * @param {ng.AnimateService} $animate
    * @param {*} $interpolate
    */
   constructor(
     $element: Element,
-    $attrs: import("../../core/compile/attributes.js").Attributes,
-    $scope: import("../../core/scope/scope.js").Scope,
-    $animate: any,
+    $attrs: ng.Attributes,
+    $scope: ng.Scope,
+    $animate: ng.AnimateService,
     $interpolate: any,
   );
   $$controls: any[];
@@ -103,7 +103,7 @@ export class FormController {
   /** @type {FormController|Object} */
   $$parentForm: FormController | any;
   $$element: Element;
-  $$animate: any;
+  $$animate: import("../../interface.ts").AnimateService;
   $error: {};
   $$success: {};
   $pending: any;

@types/directive/form/form.d.ts

@@ -1,8 +1,8 @@
 /**
- * @param {*}  $animate
+ * @param {ng.AnimateService} $animate
  * @returns {ng.Directive}
  */
-export function ngIfDirective($animate: any): ng.Directive;
+export function ngIfDirective($animate: ng.AnimateService): ng.Directive;
 export namespace ngIfDirective {
   let $inject: string[];
 }

@types/directive/if/if.d.ts

@@ -1,15 +1,15 @@
 /**
  *
- * @param {*} $templateRequest
+ * @param {ng.TemplateRequestService} $templateRequest
  * @param {import("../../services/anchor-scroll/anchor-scroll.js").AnchorScrollFunction} $anchorScroll
- * @param {*} $animate
+ * @param {ng.AnimateService} $animate
  * @param {import('../../services/exception/interface.ts').ErrorHandler} $exceptionHandler
  * @returns {import('../../interface.ts').Directive}
  */
 export function ngIncludeDirective(
-  $templateRequest: any,
+  $templateRequest: ng.TemplateRequestService,
   $anchorScroll: import("../../services/anchor-scroll/anchor-scroll.js").AnchorScrollFunction,
-  $animate: any,
+  $animate: ng.AnimateService,
   $exceptionHandler: import("../../services/exception/interface.ts").ErrorHandler,
 ): import("../../interface.ts").Directive;
 export namespace ngIncludeDirective {

@types/directive/include/include.d.ts

@@ -1,8 +1,8 @@
-export function ngMessagesDirective($animate: any): {
-  require: string;
-  restrict: string;
-  controller: ($element: any, $scope: any, $attrs: any) => NgMessageCtrl;
-};
+/**
+ * @param {ng.AnimateService} $animate
+ * @returns {ng.Directive}
+ */
+export function ngMessagesDirective($animate: ng.AnimateService): ng.Directive;
 export namespace ngMessagesDirective {
   let $inject: string[];
 }
@@ -18,46 +18,6 @@ export namespace ngMessagesIncludeDirective {
   let $inject_1: string[];
   export { $inject_1 as $inject };
 }
-export const ngMessageDirective: (
-  any: any,
-) => import("../../interface.ts").Directive;
-export const ngMessageExpDirective: (
-  any: any,
-) => import("../../interface.ts").Directive;
-export const ngMessageDefaultDirective: (
-  any: any,
-) => import("../../interface.ts").Directive;
-declare class NgMessageCtrl {
-  /**
-   * @param {Element} $element
-   * @param {import('../../core/scope/scope.js').Scope} $scope
-   * @param {import('../../core/compile/attributes').Attributes} $attrs
-   * @param {*} $animate
-   */
-  constructor(
-    $element: Element,
-    $scope: import("../../core/scope/scope.js").Scope,
-    $attrs: any,
-    $animate: any,
-  );
-  $element: Element;
-  $scope: import("../../interface.ts").Scope;
-  $attrs: any;
-  $animate: any;
-  latestKey: number;
-  nextAttachId: number;
-  messages: {};
-  renderLater: boolean;
-  cachedCollection: {};
-  head: any;
-  default: any;
-  getAttachId(): number;
-  render(collection?: {}): void;
-  reRender(): void;
-  register(comment: any, messageCtrl: any, isDefault: any): void;
-  deregister(comment: any, isDefault: any): void;
-  findPreviousMessage(parent: any, comment: any): any;
-  insertMessageNode(parent: any, comment: any, key: any): void;
-  removeMessageNode(parent: any, comment: any, key: any): void;
-}
-export {};
+export const ngMessageDirective: (any: any) => ng.Directive;
+export const ngMessageExpDirective: (any: any) => ng.Directive;
+export const ngMessageDefaultDirective: (any: any) => ng.Directive;