Simplify pubsub

Author: tolyo

@types/services/pubsub/pubsub.d.ts

@@ -14,17 +14,18 @@ export class PubSubProvider {
    */
   $get: () => PubSub;
 }
+/**
+ * A lightweight PubSub implementation optimized for
+ * modern JavaScript engines.
+ *
+ * Features:
+ *  - Constant-time subscribe / unsubscribe
+ *  - Minimal memory churn & stable hidden-class shapes
+ *  - Fast publish using flat arrays
+ *  - Preserves listener order
+ */
 export class PubSub {
   static $nonscope: boolean;
-  /**
-   * Runs a function asynchronously.
-   *
-   * @private
-   * @param {Function} fn Function to run.
-   * @param {Object} context Context in which to run the function.
-   * @param {Array} args Arguments to pass to the function.
-   */
-  private static runAsync;
   disposed: boolean;
   /**
    * The next available subscription key.  Internally, this is an index into the

docs/content/docs/service/eventBus.md

@@ -11,7 +11,7 @@ A messaging service, backed by an instance of
 the original
 [Google Closure PubSub](https://google.github.io/closure-library/api/goog.pubsub.PubSub.html)
 but uses
-[`Promise.resolve()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve)
+[`queueMicrotask`](https://developer.mozilla.org/en-US/docs/Web/API/Window/queueMicrotask)
 instead of
 [`Window.setTimeout()`](https://developer.mozilla.org/en-US/docs/Web/API/Window/setTimeout)
 for its async implementation. `$eventBus` allows communication between an

src/services/pubsub/pubsub.js

@@ -18,6 +18,16 @@ export class PubSubProvider {
   $get = () => this.eventBus;
 }
 
+/**
+ * A lightweight PubSub implementation optimized for
+ * modern JavaScript engines.
+ *
+ * Features:
+ *  - Constant-time subscribe / unsubscribe
+ *  - Minimal memory churn & stable hidden-class shapes
+ *  - Fast publish using flat arrays
+ *  - Preserves listener order
+ */
 export class PubSub {
   static $nonscope = true;
   /**
@@ -162,20 +172,6 @@ export class PubSub {
     return key;
   }
 
-  /**
-   * Runs a function asynchronously.
-   *
-   * @private
-   * @param {Function} fn Function to run.
-   * @param {Object} context Context in which to run the function.
-   * @param {Array} args Arguments to pass to the function.
-   */
-  static runAsync(fn, context, args) {
-    queueMicrotask(() => {
-      fn.apply(context, args);
-    });
-  }
-
   /**
    * Unsubscribes a function from a topic.  Only deletes the first match found.
    * Returns a Boolean indicating whether a subscription was removed.
@@ -263,11 +259,13 @@ export class PubSub {
       for (let i = 0, l = keys.length; i < l; i++) {
         const key = keys[i];
 
-        PubSub.runAsync(
-          this.subscriptions[key + 1],
-          this.subscriptions[key + 2],
-          args,
-        );
+        const fn = this.subscriptions[key + 1];
+
+        const context = this.subscriptions[key + 2];
+
+        queueMicrotask(() => {
+          fn.apply(context, args);
+        });
       }
 
       return true;