Skip to content

Commit d89c2cb

Browse files
committed
refactor: use platformBrowser instead of platformBrowserTesting
`platformBrowserTesting` currently does not include the right providers. See: angular/angular#60480
1 parent 2cc6b7f commit d89c2cb

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

packages/angular/build/src/builders/karma/polyfills/init_test_bed.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@
77
*/
88

99
import { getTestBed } from '@angular/core/testing';
10-
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
10+
import { platformBrowser } from '@angular/platform-browser';
11+
import { BrowserTestingModule } from '@angular/platform-browser/testing';
1112

13+
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
1214
// Initialize the Angular testing environment.
13-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
15+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
1416
errorOnUnknownElements: true,
1517
errorOnUnknownProperties: true,
1618
});

packages/angular_devkit/build_angular/src/builders/jest/init-test-bed.mjs

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@
1010
// `@angular-devkit/build-angular` rather than the user's workspace. Should look into virtual modules to support those use cases.
1111

1212
import { getTestBed } from '@angular/core/testing';
13-
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
13+
import { platformBrowser } from '@angular/platform-browser';
14+
import { BrowserTestingModule } from '@angular/platform-browser/testing';
1415

15-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
16+
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
17+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
1618
errorOnUnknownElements: true,
1719
errorOnUnknownProperties: true,
1820
});

packages/angular_devkit/build_angular/src/builders/karma/browser_builder.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,12 @@ function getBuiltInMainFile(): string {
153153
const content = Buffer.from(
154154
`
155155
import { getTestBed } from '@angular/core/testing';
156+
import { platformBrowser } from '@angular/platform-browser';
156157
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
157158
159+
// TODO(alanagius): replace with \`platformBrowserTesting\` once https://github.com/angular/angular/pull/60480 is released.
158160
// Initialize the Angular testing environment.
159-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
161+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
160162
errorOnUnknownElements: true,
161163
errorOnUnknownProperties: true
162164
});

packages/angular_devkit/build_angular/src/builders/web-test-runner/jasmine_runner.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
*/
88

99
import { getTestBed } from '@angular/core/testing';
10-
import { BrowserTestingModule, platformBrowserTesting } from '@angular/platform-browser/testing';
10+
import { platformBrowser } from '@angular/platform-browser';
11+
import { BrowserTestingModule } from '@angular/platform-browser/testing';
1112
import {
1213
getConfig,
1314
sessionFailed,
@@ -64,7 +65,8 @@ export async function runJasmineTests(jasmineEnv) {
6465
jasmine.DEFAULT_TIMEOUT_INTERVAL = config.defaultTimeoutInterval;
6566

6667
// Initialize `TestBed` automatically for users. This assumes we already evaluated `zone.js/testing`.
67-
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowserTesting(), {
68+
// TODO(alanagius): replace with `platformBrowserTesting` once https://github.com/angular/angular/pull/60480 is released.
69+
getTestBed().initTestEnvironment(BrowserTestingModule, platformBrowser(), {
6870
errorOnUnknownElements: true,
6971
errorOnUnknownProperties: true,
7072
});

0 commit comments

Comments
 (0)