Skip to content

Commit 7e2eefa

Browse files
committed
build: use version directly in typescript version for module.bazel and validate it with testing (#3010)
PR Close #3010
1 parent 21c2dc7 commit 7e2eefa

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

BUILD.bazel

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
load("@aspect_rules_js//js:defs.bzl", "js_binary")
22
load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
33
load("@devinfra_npm//:defs.bzl", "npm_link_all_packages")
4+
load("//bazel/validation:defs.bzl", "validate_ts_version_matching")
45

56
npm_link_all_packages()
67

@@ -12,7 +13,6 @@ ts_config(
1213

1314
exports_files([
1415
"package.json",
15-
".yarnrc.yml",
1616
])
1717

1818
js_binary(
@@ -28,3 +28,8 @@ js_binary(
2828
entry_point = ".yarn/releases/yarn-1.22.17.cjs",
2929
visibility = ["//bazel/integration/tests:__subpackages__"],
3030
)
31+
32+
validate_ts_version_matching(
33+
module_lock_file = "MODULE.bazel.lock",
34+
package_json = "package.json",
35+
)

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ rules_ts_ext = use_extension("@aspect_rules_ts//ts:extensions.bzl", "ext")
4949
rules_ts_ext.deps(
5050
# Obtained by: curl --silent https://registry.npmjs.org/typescript/5.9.2 | jq -r '.dist.integrity'
5151
ts_integrity = "sha512-CWBzXQrc/qOkhidw1OzBTQuYRbfyxDXJMVJ1XNwUHGROVmuaeiEm3OslpZ1RV96d7SKKjZKrSJu3+t/xlw3R9A==",
52-
ts_version_from = "//bazel:package.json",
52+
ts_version = "5.9.2",
5353
)
5454
use_repo(rules_ts_ext, "npm_typescript")
5555

MODULE.bazel.lock

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)