Skip to content

Commit 8076a69

Browse files
thePunderWomanjosephperrott
thePunderWoman
authored and
josephperrott
committed
fix(ng-dev): fix commitCheck functions for managed labels (#2544)
Some of the managed labels were incorrectly looking at type rather than scope for their commitCheck function, which resulted in always failing to match. PR Close #2544
1 parent 36f7bd9 commit 8076a69

File tree

6 files changed

+93
-18
lines changed

6 files changed

+93
-18
lines changed

‎.github/local-actions/branch-manager/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62463,19 +62463,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
6246362463
DETECTED_HTTP_CHANGE: {
6246462464
description: "Issues related to HTTP and HTTP Client",
6246562465
name: "area: common/http",
62466-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
62466+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
6246762467
repositories: [ManagedRepositories.ANGULAR]
6246862468
},
6246962469
DETECTED_COMPILER_CHANGE: {
6247062470
description: "Issues related to `ngc`, Angular's template compiler",
6247162471
name: "area: compiler",
62472-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
62472+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
6247362473
repositories: [ManagedRepositories.ANGULAR]
6247462474
},
6247562475
DETECTED_PLATFORM_BROWSER_CHANGE: {
6247662476
description: "Issues related to the framework runtime",
6247762477
name: "area: core",
62478-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
62478+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
62479+
repositories: [ManagedRepositories.ANGULAR]
62480+
},
62481+
DETECTED_PLATFORM_SERVER_CHANGE: {
62482+
description: "Issues related to server-side rendering",
62483+
name: "area: server",
62484+
commitCheck: (c) => c.scope === "platform-server",
62485+
repositories: [ManagedRepositories.ANGULAR]
62486+
},
62487+
DETECTED_ZONES_CHANGE: {
62488+
description: "Issues related to zone.js",
62489+
name: "area: zones",
62490+
commitCheck: (c) => c.scope === "zone.js",
6247962491
repositories: [ManagedRepositories.ANGULAR]
6248062492
}
6248162493
});

‎.github/local-actions/labels-sync/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45887,19 +45887,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4588745887
DETECTED_HTTP_CHANGE: {
4588845888
description: "Issues related to HTTP and HTTP Client",
4588945889
name: "area: common/http",
45890-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
45890+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4589145891
repositories: [ManagedRepositories.ANGULAR]
4589245892
},
4589345893
DETECTED_COMPILER_CHANGE: {
4589445894
description: "Issues related to `ngc`, Angular's template compiler",
4589545895
name: "area: compiler",
45896-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
45896+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4589745897
repositories: [ManagedRepositories.ANGULAR]
4589845898
},
4589945899
DETECTED_PLATFORM_BROWSER_CHANGE: {
4590045900
description: "Issues related to the framework runtime",
4590145901
name: "area: core",
45902-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
45902+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
45903+
repositories: [ManagedRepositories.ANGULAR]
45904+
},
45905+
DETECTED_PLATFORM_SERVER_CHANGE: {
45906+
description: "Issues related to server-side rendering",
45907+
name: "area: server",
45908+
commitCheck: (c) => c.scope === "platform-server",
45909+
repositories: [ManagedRepositories.ANGULAR]
45910+
},
45911+
DETECTED_ZONES_CHANGE: {
45912+
description: "Issues related to zone.js",
45913+
name: "area: zones",
45914+
commitCheck: (c) => c.scope === "zone.js",
4590345915
repositories: [ManagedRepositories.ANGULAR]
4590445916
}
4590545917
});

‎github-actions/branch-manager/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45887,19 +45887,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4588745887
DETECTED_HTTP_CHANGE: {
4588845888
description: "Issues related to HTTP and HTTP Client",
4588945889
name: "area: common/http",
45890-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
45890+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4589145891
repositories: [ManagedRepositories.ANGULAR]
4589245892
},
4589345893
DETECTED_COMPILER_CHANGE: {
4589445894
description: "Issues related to `ngc`, Angular's template compiler",
4589545895
name: "area: compiler",
45896-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
45896+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4589745897
repositories: [ManagedRepositories.ANGULAR]
4589845898
},
4589945899
DETECTED_PLATFORM_BROWSER_CHANGE: {
4590045900
description: "Issues related to the framework runtime",
4590145901
name: "area: core",
45902-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
45902+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
45903+
repositories: [ManagedRepositories.ANGULAR]
45904+
},
45905+
DETECTED_PLATFORM_SERVER_CHANGE: {
45906+
description: "Issues related to server-side rendering",
45907+
name: "area: server",
45908+
commitCheck: (c) => c.scope === "platform-server",
45909+
repositories: [ManagedRepositories.ANGULAR]
45910+
},
45911+
DETECTED_ZONES_CHANGE: {
45912+
description: "Issues related to zone.js",
45913+
name: "area: zones",
45914+
commitCheck: (c) => c.scope === "zone.js",
4590345915
repositories: [ManagedRepositories.ANGULAR]
4590445916
}
4590545917
});

‎github-actions/commit-message-based-labels/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46352,19 +46352,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4635246352
DETECTED_HTTP_CHANGE: {
4635346353
description: "Issues related to HTTP and HTTP Client",
4635446354
name: "area: common/http",
46355-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
46355+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4635646356
repositories: [ManagedRepositories.ANGULAR]
4635746357
},
4635846358
DETECTED_COMPILER_CHANGE: {
4635946359
description: "Issues related to `ngc`, Angular's template compiler",
4636046360
name: "area: compiler",
46361-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
46361+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4636246362
repositories: [ManagedRepositories.ANGULAR]
4636346363
},
4636446364
DETECTED_PLATFORM_BROWSER_CHANGE: {
4636546365
description: "Issues related to the framework runtime",
4636646366
name: "area: core",
46367-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
46367+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
46368+
repositories: [ManagedRepositories.ANGULAR]
46369+
},
46370+
DETECTED_PLATFORM_SERVER_CHANGE: {
46371+
description: "Issues related to server-side rendering",
46372+
name: "area: server",
46373+
commitCheck: (c) => c.scope === "platform-server",
46374+
repositories: [ManagedRepositories.ANGULAR]
46375+
},
46376+
DETECTED_ZONES_CHANGE: {
46377+
description: "Issues related to zone.js",
46378+
name: "area: zones",
46379+
commitCheck: (c) => c.scope === "zone.js",
4636846380
repositories: [ManagedRepositories.ANGULAR]
4636946381
}
4637046382
});

‎github-actions/unified-status-check/main.js‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47707,19 +47707,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
4770747707
DETECTED_HTTP_CHANGE: {
4770847708
description: "Issues related to HTTP and HTTP Client",
4770947709
name: "area: common/http",
47710-
commitCheck: (c) => c.type === "common/http" || c.type === "http",
47710+
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
4771147711
repositories: [ManagedRepositories.ANGULAR]
4771247712
},
4771347713
DETECTED_COMPILER_CHANGE: {
4771447714
description: "Issues related to `ngc`, Angular's template compiler",
4771547715
name: "area: compiler",
47716-
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
47716+
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
4771747717
repositories: [ManagedRepositories.ANGULAR]
4771847718
},
4771947719
DETECTED_PLATFORM_BROWSER_CHANGE: {
4772047720
description: "Issues related to the framework runtime",
4772147721
name: "area: core",
47722-
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
47722+
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
47723+
repositories: [ManagedRepositories.ANGULAR]
47724+
},
47725+
DETECTED_PLATFORM_SERVER_CHANGE: {
47726+
description: "Issues related to server-side rendering",
47727+
name: "area: server",
47728+
commitCheck: (c) => c.scope === "platform-server",
47729+
repositories: [ManagedRepositories.ANGULAR]
47730+
},
47731+
DETECTED_ZONES_CHANGE: {
47732+
description: "Issues related to zone.js",
47733+
name: "area: zones",
47734+
commitCheck: (c) => c.scope === "zone.js",
4772347735
repositories: [ManagedRepositories.ANGULAR]
4772447736
}
4772547737
});

‎ng-dev/pr/common/labels/managed.ts‎

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,34 @@ export const managedLabels = createTypedObject(ManagedLabel)({
4747
DETECTED_HTTP_CHANGE: {
4848
description: 'Issues related to HTTP and HTTP Client',
4949
name: 'area: common/http',
50-
commitCheck: (c: Commit) => c.type === 'common/http' || c.type === 'http',
50+
commitCheck: (c: Commit) => c.scope === 'common/http' || c.scope === 'http',
5151
repositories: [ManagedRepositories.ANGULAR],
5252
},
5353
DETECTED_COMPILER_CHANGE: {
5454
description: "Issues related to `ngc`, Angular's template compiler",
5555
name: 'area: compiler',
56-
commitCheck: (c: Commit) => c.type === 'compiler' || c.type === 'compiler-cli',
56+
commitCheck: (c: Commit) => c.scope === 'compiler' || c.scope === 'compiler-cli',
5757
repositories: [ManagedRepositories.ANGULAR],
5858
},
5959
DETECTED_PLATFORM_BROWSER_CHANGE: {
6060
description: 'Issues related to the framework runtime',
6161
name: 'area: core',
62-
commitCheck: (c: Commit) => c.type === 'platform-browser' || c.type === 'core',
62+
commitCheck: (c: Commit) =>
63+
c.scope === 'platform-browser' ||
64+
c.scope === 'core' ||
65+
c.scope === 'platform-browser-dynamic',
66+
repositories: [ManagedRepositories.ANGULAR],
67+
},
68+
DETECTED_PLATFORM_SERVER_CHANGE: {
69+
description: 'Issues related to server-side rendering',
70+
name: 'area: server',
71+
commitCheck: (c: Commit) => c.scope === 'platform-server',
72+
repositories: [ManagedRepositories.ANGULAR],
73+
},
74+
DETECTED_ZONES_CHANGE: {
75+
description: 'Issues related to zone.js',
76+
name: 'area: zones',
77+
commitCheck: (c: Commit) => c.scope === 'zone.js',
6378
repositories: [ManagedRepositories.ANGULAR],
6479
},
6580
});

0 commit comments

Comments
 (0)