-
Notifications
You must be signed in to change notification settings - Fork 115
Description
We're trying to spin up a dev container to build Angular / a few other projects in a similar fashion across all machines, but running into an issue with webdriver-manager not being able to download Linux appropriately (and thus yarn install fails from a post-install step)
I know there's some outstanding issues (#476 & #510) reference issues on the M1 architecture in the Host OS, but we're seeing the binary not download when running on a Linux Container (which still has arm64 arch).
Some primitive instrumentation (polite description of monkey patching) lead us to the following:
webdriver-manager/lib/binaries/chrome_xml.ts
Line 100 in fff7682
| if (this.osarch === 'arm64' && this.ostype === 'Darwin' && item.includes('m1')) { |
which looks like it addresses the issue on the M1. Problem is our values for osarch and ostype are arm64 & Linux respectively. Patching in the following works, but not sure if this would be acceptable for all arm64 scenarios.
if (this.osarch === 'arm64' && this.ostype === 'Linux') {
itemFound = item;
}Can anyone shed some light? Happy to submit a PR / any tests required, if this indeed is a good solution