-
Notifications
You must be signed in to change notification settings - Fork 79
Open
Labels
Category: CodingChanges to code base or refactored code that doesn't fix a bug.Changes to code base or refactored code that doesn't fix a bug.First Timers OnlyGood for newcomers.Good for newcomers.Hacktoberfest
Description
Describe the bug
Streamwise messages are not showing on zulip stat to admin because the condition to check streamwise messages is wrong.
We need to delete this condition of checking all streamwise messages by checking the message in the newcomer stream, as it is not required. To test the message
To Reproduce
Steps to reproduce the behavior:
- Go to http://localhost:8000/admin/osp/userinformation/
- Edit one of the admin user-information and insert 345277 in zulip id.
- Now go to this http://localhost:3000/ and log in using the credentials of the user which you have edited previously.
- Reload the zulip stats and now you can see that streamwise messages do not show up.
Expected behavior
Streamwise messages do not show up when the student has no message in the newcomer stream.
Screenshots
Desktop (please complete the following information):
- OS: Ubuntu
- Browser: Chrome
- Version: _
How to solve
To solve this issue remove the condition of checking the stream messages by checking message in newcomer stream.
https://github.com/anitab-org/open-source-programs-web/blob/ab18727af5a5e30829e4d07935a218c6d8a02762/src/components/Zulip.js#L39-L51
I have tested by removing it, it is working fine.
Time Required to solve this issue
- 10 to 15 minutes.
Metadata
Metadata
Assignees
Labels
Category: CodingChanges to code base or refactored code that doesn't fix a bug.Changes to code base or refactored code that doesn't fix a bug.First Timers OnlyGood for newcomers.Good for newcomers.Hacktoberfest
