test: Revoking admin status #181
Conversation
…ser, revoking a self-admin
|
Please send PRs only to approved issues. |
There was a problem hiding this comment.
Thank you for sending the PR @sharifa2708 🎉
From what I'm seeing there is some logic missing from the tests because the tests should fail when you don't send an auth header. Feel free to ask any questions regarding my change requests.
| db.session.add(self.other_user) | ||
| db.session.commit() | ||
|
|
||
| def test_revoke_admin_admin(self): |
There was a problem hiding this comment.
| def test_revoke_admin_admin(self): | |
| def test_revoke_admin_role(self): |
| db.session.commit() | ||
|
|
||
| def test_revoke_admin_admin(self): | ||
| if (self.verified_user.is_admin and self.other_user.is_admin): |
There was a problem hiding this comment.
remove this if statement. you want to test the api, with this values regardless of their values
| # self.assertEqual(expected_response, json.loads(actual_response.data)) | ||
|
|
||
| def test_revoke_self_admin(self): | ||
| if(self.verified_user.is_admin and self.verified_user==self.other_user): |
|
|
||
|
|
||
| def test_revoke_user(self): | ||
| if(self.verified_user.is_admin and self.other_user.is_admin == 0): |
| def test_revoke_admin_admin(self): | ||
| if (self.verified_user.is_admin and self.other_user.is_admin): | ||
| expected_response = {'message': 'User admin status was revoked.'} | ||
| actual_response = self.client.get('/admin/remove', follow_redirects=True) |
There was a problem hiding this comment.
to test api, you have to create header arguments and then use it on the api call. Example: auth_header, otherwise the calls will fail, because the test user isn't authenticated. Do this for the other tests
isabelcosta
added
the
Category: Quality Assurance
| super(TestListAdminsApi, self).setUp() | ||
|
|
||
| self.verified_user = UserModel( | ||
| name=user1['name'], |
There was a problem hiding this comment.
space between variables and operator, follow everywhere, complying to PEP8
| self.assertEqual(expected_response, json.loads(actual_response.data)) | ||
|
|
||
|
|
||
| # def test_revoke_non_user(self): |
There was a problem hiding this comment.
No commented code in PRs please.
|
@sharifa2708 are you still working on this? If you're not, no problem :) We can make the issue available for other contributors. |
|
Will close this issue and make it available again for lack of updates. |
Description
Added tests for revoking admin status.
Fixes #142
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
NA
Checklist:
Code/Quality Assurance Only