optimise code for repeated code in `app/api/dao/user.py` `get_user_dashboard`

[annabauza]

Description

As a developer,
I need optimise code in method get_user_dashboard of app/api/dao/user.py
so that I can avoid code repetition.

Acceptance Criteria

Update [Required]

• not repeatable code

Definition of Done

• All of the required items are completed.
• All test passing.
• Approval by 1 mentor.

[EfthymiaKostaki]

Hello, I have some ideas on this issue can I start working on that?

[isabelcosta]

@EfthymiaKostaki please address what I asked on your current PR, and then I can assign this to you, while you wait for PR review :)

[EfthymiaKostaki]

Hello since you have accepted my changes in the pull request can I start working on this issue? Will I need to update the test cases for validation or make sure that all the current test cases are passing? Do you have any other requirements I should keep in mind?

[isabelcosta]

@EfthymiaKostaki sure you can work on this :) I will assign this to you. I would say you have to optimize the code and fix any tests if needed. Although I think this does not affect the way the API is called. So you have to be certain that the tests are running successfully as they were before your change.

[EfthymiaKostaki]

Hello again, @isabelcosta while running the tests with no changes to the code and as it is updated now on GitHub I am seeing this:

Is this the correct outcome I should be seeing? And after making the changes in the code I am expecting it to remain the same?

Thanks again!

[NenadPantelic]

@isabelcosta What's going on with this issue?

[isabelcosta]

@NenadPantelic could you look into this PR #545, as far as i know, we need to review that PR and help the contributor.

@EfthymiaKostaki do you still have this doubt #418 (comment)?