test: Check if email is sent for new mentorship relation requests #536

gaurivn · 2020-04-09T21:24:32Z

Description

Testing whether email is sent for valid mentorship relation requests and whether email is not sent for invalid mentorship relation requests with 2 added unit tests. Changed the version of MarkupSafe (to 1.1.1) in requirements.txt.

Fixes #432

Type of Change:

Delete irrelevant options.

Quality Assurance

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tests were added to check if email was sent for new mentorship relation requests.

Checklist:

Delete irrelevant options.

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
Update requirements.txt

Code/Quality Assurance Only

My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

isabelcosta

@gaurivn I requested some changes, let me know if you have any doubt or disagree with any of the changes :)

tests/mentorship_relation/test_api_create_request.py

isabelcosta · 2020-04-12T15:51:16Z

app/api/email_utils.py

@@ -149,3 +149,5 @@ def send_email_new_request(user_sender, user_recipient, notes, sender_role):
    )
    subject = "Mentorship System - You have got new relation request"
    send_email(user_recipient.email, subject, html)
+


can you undo these changes? just to keep the changes to test module?

can you remove these changes? I can merge them but if you could take these off as well. This seems like style format changes, that can be done in another PR

gaurivn · 2020-04-12T15:56:44Z

Sure @isabelcosta thank you, I will make the changes asap.

gaurivn · 2020-04-12T16:59:47Z

@isabelcosta , I made the changes, kindly review them and please tell if I have to make further changes.

isabelcosta

there is left just some indentation fixes @gaurivn

isabelcosta · 2020-04-12T17:04:02Z

tests/mentorship_relation/test_api_send_request.py

@@ -45,6 +53,8 @@ def test_fail_send_request_bad_mentor_id(self):
                                           headers=auth_header, content_type='application/json',
                                           data=json.dumps(test_payload))
        self.assertEqual(404, actual_response.status_code)
+	self.assertEqual(1, len(outbox))


is this well indented?

isabelcosta · 2020-04-12T17:04:10Z

tests/mentorship_relation/test_api_send_request.py

@@ -62,9 +72,45 @@ def test_fail_send_request_bad_user_id(self):
                                           headers=auth_header, content_type='application/json',
                                           data=json.dumps(test_payload))
        self.assertEqual(400, actual_response.status_code)
+	self.assertEqual(1, len(outbox))


is this well indented?

@isabelcosta , I have made the required indentation changes after removing unnecessary commits, please review and suggest changes if any.

isabelcosta · 2020-04-12T17:05:11Z

app/api/email_utils.py

@@ -149,3 +149,5 @@ def send_email_new_request(user_sender, user_recipient, notes, sender_role):
    )
    subject = "Mentorship System - You have got new relation request"
    send_email(user_recipient.email, subject, html)
+


can you remove these changes? I can merge them but if you could take these off as well. This seems like style format changes, that can be done in another PR

gaurivn · 2020-04-12T18:27:17Z

@isabelcosta , when I checked in gedit editor, it shows proper indentation. I thought it was because of mixing tabs and spaces. I had removed the extra lines under email_utils.py, got a bit confused with the commit conflicts. Can you please check once again and tell if there are any changes I can make.

gaurivn · 2020-04-13T19:19:15Z

@isabelcosta , it is fixed now, I used spaces instead of tab, please review.

isabelcosta

Can you please check again code indentation @gaurivn :)

isabelcosta · 2020-05-10T21:32:39Z

tests/mentorship_relation/test_api_send_request.py

@@ -14,6 +15,12 @@
 class TestSendRequestApi(MentorshipRelationBaseTestCase):
    def setUp(self):
        super(TestSendRequestApi, self).setUp()
+	self.notes_example = 'description of a good mentorship relation'


I think this is not well indented and that is why TravisCI is failing

I indented it properly, replaced tab with proper spaces.

… into patchone

sumit-badsara · 2020-09-02T19:19:12Z

tests/mentorship_relation/test_api_send_request.py

@@ -29,9 +36,10 @@ def test_fail_send_request_bad_mentee_id(self):
                                           headers=auth_header, content_type='application/json',
                                           data=json.dumps(test_payload))
        self.assertEqual(404, actual_response.status_code)
+        self.assertEqual(1, len(outbox))


outbox isn't defined here.

@gaurivn can you please define how to get the outbox from the user email

@isabelcosta @BadduCoder, can I remove the outbox line

@gaurivn I did a quick search on google to try to figure out how to use the outbox concept, and I found this in the official documentation of Flask-Mail: https://pythonhosted.org/Flask-Mail/#unit-tests-and-suppressing-emails
Can you see if you can fix the outbox usage in this test, before deciding to not use this?

This issue goal is about using something in the code to figure out if the email is being sent, and I think this can be done through this outbox concept

sumit-badsara

@gaurivn outbox isn't imported/defined anywhere, which is causing the travis ci failure. Fix that first, and for indentation (maybe use some linter)?

devkapilbansal · 2021-02-20T21:13:26Z

@gaurivn can you please make the necessary changes?

vj-codes · 2021-03-17T19:17:42Z

@gaurivn closing due to inactivity
Thank you for your contribution :)

test: Check if email is sent for new mentorship relation requests

87d0bc6

isabelcosta requested changes Apr 12, 2020

View reviewed changes

isabelcosta added the Type: Testing UI Tests, Integration Tests, Travis CI, etc. label Apr 12, 2020

Made changes

f3f3c64

isabelcosta requested changes Apr 12, 2020

View reviewed changes

to be force pushed

55f4f17

gaurivn force-pushed the patchone branch from 21a6e11 to 55f4f17 Compare April 19, 2020 17:07

removed space in app/api/email_utils.py

3e63f1e

isabelcosta requested changes May 10, 2020

View reviewed changes

gaurivn added 2 commits May 11, 2020 02:06

Merge branch 'develop' of https://github.com/systers/mentorship-backend…

1cbae6d

… into patchone

Fixed indentation

f39e011

sumit-badsara reviewed Sep 2, 2020

View reviewed changes

sumit-badsara suggested changes Sep 2, 2020

View reviewed changes

devkapilbansal added the Status: Changes Requested Changes are required to be done by the PR author. label Feb 20, 2021

vj-codes closed this Mar 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Check if email is sent for new mentorship relation requests #536

test: Check if email is sent for new mentorship relation requests #536

gaurivn commented Apr 9, 2020

isabelcosta left a comment

isabelcosta Apr 12, 2020

isabelcosta Apr 12, 2020

gaurivn commented Apr 12, 2020 •

edited

Loading

gaurivn commented Apr 12, 2020

isabelcosta left a comment

isabelcosta Apr 12, 2020

isabelcosta Apr 12, 2020

gaurivn Apr 19, 2020

isabelcosta Apr 12, 2020

gaurivn commented Apr 12, 2020

gaurivn commented Apr 13, 2020

isabelcosta left a comment

isabelcosta May 10, 2020

gaurivn May 10, 2020

sumit-badsara Sep 2, 2020

isabelcosta Sep 4, 2020

gaurivn Sep 5, 2020

isabelcosta Sep 6, 2020

sumit-badsara left a comment •

edited

Loading

devkapilbansal commented Feb 20, 2021

vj-codes commented Mar 17, 2021

test: Check if email is sent for new mentorship relation requests #536

test: Check if email is sent for new mentorship relation requests #536

Conversation

gaurivn commented Apr 9, 2020

Description

Type of Change:

How Has This Been Tested?

Checklist:

isabelcosta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaurivn commented Apr 12, 2020 • edited Loading

gaurivn commented Apr 12, 2020

isabelcosta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaurivn commented Apr 12, 2020

gaurivn commented Apr 13, 2020

isabelcosta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sumit-badsara left a comment • edited Loading

Choose a reason for hiding this comment

devkapilbansal commented Feb 20, 2021

vj-codes commented Mar 17, 2021

gaurivn commented Apr 12, 2020 •

edited

Loading

sumit-badsara left a comment •

edited

Loading