Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: email verification date type changed from datetime to float (#447) #460

Closed
wants to merge 1 commit into from
Closed

fix: email verification date type changed from datetime to float (#447) #460

wants to merge 1 commit into from

Conversation

SanujBansal
Copy link

Description

email verification date type changed from datetime to float to save and send response in unix float format

Fixes #447

Type of Change:

Delete irrelevant options.

  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Screenshot from 2020-02-27 02-42-38

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have made corresponding changes to the documentation

Code/Quality Assurance Only

  • My changes generate no new warnings
  • Any dependent changes have been published in downstream modules

@SanujBansal SanujBansal mentioned this pull request Mar 1, 2020
Open
@isabelcosta isabelcosta added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request. labels Mar 5, 2020
isabelcosta
isabelcosta approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @SanujBansal !
Thank you for your contribution!

@isabelcosta
Copy link
Member

Could you please fix the merge conflicts @SanujBansal :)

ramitsawhney27
ramitsawhney27 reviewed Mar 12, 2020
View reviewed changes
app/api/dao/user.py
@@ -1,5 +1,6 @@
from datetime import datetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to import datetime if you're no longer using it?

@rpattath
Copy link
Member

rpattath commented Apr 3, 2020

Tested and Get User gave the attached output.

Screenshot from 2020-04-03 14-27-16

@isabelcosta
Copy link
Member

isabelcosta commented Apr 5, 2020 •
edited
Loading

Tested and Get User gave the attached output.

Screenshot from 2020-04-03 14-27-16

@rpattath it does not match what is on the description of the PR 🤔 I will try to troubleshoot this with you on Zulip and understand this because the code seems to do what is supposed to. I have to test it as well
And thank you again for trying this testing process with us 🙌

@isabelcosta
Copy link
Member

@SanujBansal could you please fix the merge conflicts?

@devkapilbansal
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramitsawhney27 ramitsawhney27 ramitsawhney27 left review comments

@isabelcosta isabelcosta isabelcosta approved these changes

Assignees
No one assigned
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email verification date should be hold and returned by backend as UNIX float
5 participants
@SanujBansal @isabelcosta @rpattath @devkapilbansal @ramitsawhney27