Skip to content

OSError in Windows not being caught #618

Open
@sumit-badsara

Description

Describe the bug

When there is some invalid argument, we expect it to be caught by python under ValueError.
But In the case of passing invalid timestamp in test test_dao_create_mentorship_relation_with_good_args_but_invalid_timestamp.
It get's caught on other OS, but for Windows It throws OSError (Another Exception) which is not getting caught by ValueError.

To Reproduce
(Steps for windows only)

  1. Run python unittests (there should be one test failure)
  2. See the error

Expected behavior
The test should pass and no test should have been failed.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Category: CodingChanges to code base or refactored code that doesn't fix a bug.Help WantedExtra attention is needed.Status: AvailableIssue was approved and available to claim or abandoned for over 3 days.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions