Skip to content

Performed manual test and report of POST/login api #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Performed manual test and report of POST/login api #821

wants to merge 2 commits into from

Conversation

vj-codes
Copy link
Member

@vj-codes vj-codes commented Sep 2, 2020

Description

Tested step by step and added report for POST/login

Fixes #753

Type of Change:

  • Code- Quality Assurance
  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@vj-codes vj-codes added Open Source Hack Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 2, 2020
@vj-codes vj-codes requested a review from isabelcosta September 2, 2020 11:59
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #821 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #821   +/-   ##
========================================
  Coverage    95.84%   95.84%           
========================================
  Files           95       95           
  Lines         5200     5200           
========================================
  Hits          4984     4984           
  Misses         216      216

rpattath
rpattath approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@rpattath rpattath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @vj-codes ! Make sure you open issue for the failed tests if there are no existing issues for them.

devkapilbansal
devkapilbansal suggested changes Jan 17, 2021
View reviewed changes
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vj-codes it would be better if the images are uploaded to github cloud and then used here.

@devkapilbansal
Copy link
Member

Hi @vj-codes please make the necessary changes

@devkapilbansal devkapilbansal added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Feb 18, 2021
@vj-codes
Copy link
Member Author

@devkapilbansal ahh I almost forgot about this PR, will close this later as I don't have the time as my exams are near would like to make the issue available for others rather than putting the PR on hold :)

@devkapilbansal
Copy link
Member

Closing this PR and making the issue available

@vj-codes vj-codes deleted the login_apiOSH branch April 12, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devkapilbansal devkapilbansal devkapilbansal requested changes

@rpattath rpattath rpattath approved these changes

@isabelcosta isabelcosta Awaiting requested review from isabelcosta isabelcosta is a code owner

Assignees
No one assigned
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform manual testing and report POST /login API
4 participants
@vj-codes @devkapilbansal @rpattath @mayburgos