Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Quality Assurance table for Delete Task API #757 #816

Closed
wants to merge 4 commits into from

Conversation

dowenrei
Copy link

@dowenrei dowenrei commented Sep 2, 2020

Description

Added test cases for Delete Task API and create a heading "Task" for Create, Update and Delete Task.
Fixes #757

Type of Change:

  • Quality Assurance

Code/Quality Assurance Only

  • [/ ] My changes generate no new warnings

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #816 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #816   +/-   ##
========================================
  Coverage    95.84%   95.84%           
========================================
  Files           95       95           
  Lines         5200     5200           
========================================
  Hits          4984     4984           
  Misses         216      216           


**Service:** DELETE /mentorship_relation/{request_id}/task/{task_id}
| Test Case | Outcome |
Copy link

@paritoshsinghrahar paritoshsinghrahar Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| ------------- | ------------- |
| Logged in user delete a task from an existing request in the ACCEPTED state| Success |
| Logged in user tries to delete a task whose id does not exist from an existing request in the ACCEPTED state (the task does not exist) | Fail |
| Logged in user tries to delete a task from a non-existing request (Mentorship relation does not exist) in the ACCEPTED state | Fail |
| Logged in user tries to delete a task from a request which the user is not a mentor nor a mentee | Fail |
| Non-Logged in user tries to delete a task from an existing request in the ACCEPTED state  | Fail |

A nitpick. Can you uniformly space out the table in markdown for uniformity with other tables?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I check on github, it looks fine. Do you mean changing the spacing at the code (as shown below)?
DeleteTask

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, precisely.

@paritoshsinghrahar paritoshsinghrahar added Status: Needs Review PR needs an additional review or a maintainer's review. Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Sep 29, 2020
@rpattath rpattath added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. labels Oct 21, 2020
@devkapilbansal
Copy link
Member

@dowenrei can you please resolve the merge conflicts??

@devkapilbansal devkapilbansal added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Feb 18, 2021
@devkapilbansal
Copy link
Member

@dowenrei are you working on this?

@dowenrei
Copy link
Author

@dowenrei can you please resolve the merge conflicts??

I'm not authorized to solve this conflict.

@devkapilbansal
Copy link
Member

@dowenrei can you please resolve the merge conflicts??

I'm not authorized to solve this conflict.

You can since this is a pull request from your fork. Just make the necessary changes locally and push them

@vj-codes
Copy link
Member

@dowenrei hey any updates?

@vj-codes
Copy link
Member

@dowenrei closing this due to inactivity
Let us know if you would like to continue again and thank you for your contribution :)

@vj-codes vj-codes closed this Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Quality Assurance table for Delete Task API
5 participants