Test Windows

Author: ankane

.github/workflows/build.yml

@@ -6,16 +6,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [windows-2025]
-        elasticsearch-version: [9]
+        os: [windows-2022]
+        elasticsearch-version: [8]
     steps:
       - uses: actions/checkout@v4
       - uses: ./.
         with:
           elasticsearch-version: ${{ matrix.elasticsearch-version }}
-          # plugins: |
-          #   analysis-kuromoji
-          #   analysis-smartcn
+          plugins: |
+            analysis-kuromoji
+            analysis-smartcn
           config: |
             cluster.name: my-cluster
             http.port: 9201

index.js

@@ -60,10 +60,15 @@ function run() {
   }
 }
 
+// only use with validated input
+// https://github.com/nodejs/node/issues/52554
 function runBat() {
   const args = Array.from(arguments);
   console.log(args.join(' '));
   const command = args.shift();
+  if (!fs.existsSync(command)) {
+    throw 'Bat not found';
+  }
   const ret = spawnSync(command, args, {stdio: 'inherit', shell: true});
   if (ret.status !== 0) {
     throw ret.error;
@@ -166,7 +171,7 @@ function installPlugins() {
 
     // validate
     plugins.forEach( function(plugin) {
-      if (!/^\w\S+$/.test(plugin)) {
+      if (!/^\w(\w|-)+$/i.test(plugin)) {
         throw `Invalid plugin: ${plugin}`;
       }
     });
@@ -176,14 +181,16 @@ function installPlugins() {
     const versionParts = elasticsearchVersion.split('.');
     const atOnce = parseInt(versionParts[0]) >= 7 && parseInt(versionParts[1]) >= 6;
     let pluginCmd = path.join(esHome, 'bin', 'elasticsearch-plugin');
+    let runCmd = run;
     if (isWindows()) {
-      throw 'This action does not support plugins on Windows';
+      pluginCmd += '.bat';
+      runCmd = runBat;
     }
     if (atOnce) {
-      run(pluginCmd, 'install', '--silent', '--batch', ...plugins);
+      runCmd(pluginCmd, 'install', '--silent', '--batch', ...plugins);
     } else {
       plugins.forEach( function(plugin) {
-        run(pluginCmd, 'install', '--silent', '--batch', plugin);
+        runCmd(pluginCmd, 'install', '--silent', '--batch', plugin);
       });
     }
   }