enforce proper encoding on lock file, mypy typing, and ruff tooling

Author: CameronBrooks11

.github/workflows/ci.yml

@@ -14,6 +14,45 @@ env:
   VCPKG_COMMIT: "66c0373dc7fca549e5803087b9487edfe3aca0a1"
 
 jobs:
+  python-lint:
+    name: Python Linting (ruff)
+    runs-on: ubuntu-24.04
+    timeout-minutes: 10
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Validate Python lockfile
+        shell: bash
+        run: |
+          set -euo pipefail
+          LOCKFILE="requirements-lock.txt"
+          test -f "$LOCKFILE"
+          if od -An -tx1 "$LOCKFILE" | tr -s ' ' '\n' | grep -qx '00'; then
+            echo "ERROR: $LOCKFILE contains NUL bytes (binary corruption)" >&2
+            exit 1
+          fi
+          iconv -f UTF-8 -t UTF-8 "$LOCKFILE" > /dev/null 2>&1
+          echo "OK: $LOCKFILE is valid UTF-8 and contains no NUL bytes"
+
+      - name: Setup Python and dependencies
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.12"
+          cache: "pip"
+          cache-dependency-path: requirements-lock.txt
+
+      - name: Install Python dependencies
+        run: |
+          python -m pip install --upgrade pip
+          python -m pip install -r requirements-lock.txt
+
+      - name: Run ruff checks
+        run: |
+          ruff check tests --output-format=github
+          ruff format --check tests
+
   python-typecheck:
     name: Python Type Checking (mypy)
     runs-on: ubuntu-24.04

pyproject.toml

@@ -1,3 +1,24 @@
+[tool.ruff]
+line-length = 120
+target-version = "py312"
+exclude = [
+    "build",
+    "build-server",
+    "build-windows-server",
+    "build-windows-server-release",
+    "build-test",
+    "vcpkg_installed",
+]
+
+[tool.ruff.lint]
+select = ["E", "F"]
+
+[tool.ruff.format]
+quote-style = "double"
+indent-style = "space"
+skip-magic-trailing-comma = false
+line-ending = "auto"
+
 [tool.pytest.ini_options]
 minversion = "7.0"
 addopts = "--strict-markers -ra -vv --tb=short"

tests/conftest.py

@@ -30,9 +30,7 @@ def _find_server_executable(root: Path) -> Path:
         if path.exists() and path.is_file():
             return path.resolve()
         # Warn but fall back if env var points to nowhere
-        print(
-            f"WARNING: FLUXGRAPH_SERVER_EXE={env_path} does not exist. Falling back to search."
-        )
+        print(f"WARNING: FLUXGRAPH_SERVER_EXE={env_path} does not exist. Falling back to search.")
 
     # Search common build locations
     names = ["fluxgraph-server.exe", "fluxgraph-server"]
@@ -112,11 +110,7 @@ def has_required_bindings(path: Path) -> bool:
         has_bindings = has_required_bindings(python_proto_dir)
 
     if not has_bindings:
-        missing = [
-            filename
-            for filename in required_files
-            if not (python_proto_dir / filename).is_file()
-        ]
+        missing = [filename for filename in required_files if not (python_proto_dir / filename).is_file()]
         pytest.fail(
             "Python protobuf bindings missing after generation.\n"
             f"Directory: {python_proto_dir}\n"
@@ -202,9 +196,7 @@ def get_logs(self) -> str:
 
 
 @pytest.fixture
-def fluxgraph_server(
-    server_exe: Path, free_port: int, proto_bindings: Path
-) -> Iterator[ServerProcess]:
+def fluxgraph_server(server_exe: Path, free_port: int, proto_bindings: Path) -> Iterator[ServerProcess]:
     """
     Start a fluxgraph-server instance on a random port.
     Yields a ServerProcess object.
@@ -228,9 +220,7 @@ def fluxgraph_server(
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
             text=True,
-            cwd=str(
-                _repo_root()
-            ),  # Run from repo root so relative config paths work if needed
+            cwd=str(_repo_root()),  # Run from repo root so relative config paths work if needed
         )
         server = ServerProcess(proc, port)