Skip to content

Commit 96ec209

Browse files
Merge pull request #631 from saito-hideki/issue/630
Fixes issue related to latest ansible-core devel branch SUMMARY Fixes a bug related to updating the ansible-core devel branch. Fixes incorrect load path for json module in cgroup_perf_recap Remove unnecessary condition from seboolean integration tests Optimize conditions for selinux integration tests Fixes #630 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ansible.posix.cgroup_perf_recap ADDITIONAL INFORMATION N/A
2 parents f0b5f03 + 7b9b1f4 commit 96ec209

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
bugfixes:
3+
- ansible.posix.cgroup_perf_recap - fixes json module load path (https://github.com/ansible-collections/ansible.posix/issues/630).
4+
trivial:
5+
- ansible.posix.seboolean - remove unnecessary condition from seboolean integration tests (https://github.com/ansible-collections/ansible.posix/issues/630).
6+
- ansible.posix.selinux - optimize conditions for selinux integration tests (https://github.com/ansible-collections/ansible.posix/issues/630).

plugins/callback/cgroup_perf_recap.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132

133133
import csv
134134
import datetime
135+
import json
135136
import os
136137
import time
137138
import threading
@@ -142,7 +143,7 @@
142143

143144
from ansible.module_utils._text import to_bytes, to_text
144145
from ansible.module_utils.six import with_metaclass
145-
from ansible.parsing.ajson import AnsibleJSONEncoder, json
146+
from ansible.parsing.ajson import AnsibleJSONEncoder
146147
from ansible.plugins.callback import CallbackBase
147148

148149

tests/integration/targets/seboolean/tasks/main.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,4 @@
2020
ansible.builtin.include_tasks: seboolean.yml
2121
when:
2222
- ansible_selinux is defined
23-
- ansible_selinux
2423
- ansible_selinux.status == 'enabled'

tests/integration/targets/selinux/tasks/main.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,21 @@
1919
- name: Debug message for when SELinux is disabled
2020
ansible.builtin.debug:
2121
msg: SELinux is disabled
22-
when: ansible_selinux is defined and not ansible_selinux
22+
when: ansible_selinux is defined and ansible_selinux.status == 'disabled'
2323

2424
- name: Debug message for when SELinux is enabled and not disabled
2525
ansible.builtin.debug:
2626
msg: SELinux is {{ ansible_selinux.status }}
27-
when: ansible_selinux is defined and ansible_selinux
27+
when: ansible_selinux is defined
2828

2929
- name: Include_tasks for when SELinux is enabled
3030
ansible.builtin.include_tasks: selinux.yml
3131
when:
3232
- ansible_selinux is defined
33-
- ansible_selinux
3433
- ansible_selinux.status == 'enabled'
3534

3635
- name: Include tasks for selogin when SELinux is enabled
3736
ansible.builtin.include_tasks: selogin.yml
3837
when:
3938
- ansible_selinux is defined
40-
- ansible_selinux
4139
- ansible_selinux.status == 'enabled'

0 commit comments

Comments
 (0)