cloudfront_distribution idempotency doesn't allow for list ordering

[Alex-Richman]

SUMMARY

cloudfront_distribution compares the current and desired Aliases/LambdaFunctionAssociations configuration directly, meaning changes in the ordering of items in the lists causes an unnecessary update.

ISSUE TYPE

• Bug Report

COMPONENT NAME

cloudfront_distribution

STEPS TO REPRODUCE

cloudfront_distribution:
  state: present
  ...
   aliases: ...

EXPECTED RESULTS

List ordering for Aliases/LambdaFunctionAssociations should be ignored for idempotency checks.

ACTUAL RESULTS

--- before
+++ after
@@ -1,32 +1,30 @@
 {
     "Aliases": {
         "Items": [
+            "aa.redacted.com",
+            "as.redacted.com",
+            "bs.redacted.com",
+            "ca.redacted.com",
+            "cs.redacted.com",
+            "ha.redacted.com",
+            "is.redacted.com",
+            "la.redacted.com",
+            "ls.redacted.com",
+            "redacted.com",
             "rs.redacted.com",
             "sa.redacted.com",
-            "is.redacted.com",
-            "la.redacted.com",
-            "ca.redacted.com",
-            "as.redacted.com",
-            "ls.redacted.com",
-            "redacted.com",
-            "ss.redacted.com",
-            "bs.redacted.com",
-            "cs.redacted.com",
-            "ha.redacted.com",
-            "aa.redacted.com"
+            "ss.redacted.com"
         ]
     },
     "DefaultCacheBehavior": {
         "LambdaFunctionAssociations": {
             "Items": [
                 {
-                    "EventType": "origin-response",
-                    "IncludeBody": false,
+                    "EventType": "origin-request",
                     "LambdaFunctionARN": "arn:aws:lambda:us-east-1:redacted"
                 },
                 {
-                    "EventType": "origin-request",
-                    "IncludeBody": false,
+                    "EventType": "origin-response",
                     "LambdaFunctionARN": "arn:aws:lambda:us-east-1:redacted"
                 }
             ]

[ansibullbot]

Files identified in the description:

• plugins/modules/cloudfront_distribution.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

@Alex-Richman: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

• ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

[ansibullbot]

cc @jillr @s-hertel @tremble @willthames @wilvk @wimnat
click here for bot help