[WIP] cloudfront_distribution - fix Type error when validating distribution origins #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When defining suboptions it will ensure that the entry is there. BotoCore generally doesn't like None, so we need to purge them.
…s fron the existing config
…meout add them if the existing configuration had them, otherwise don't.
…result in unexpected changes
ansibullbot
added
WIP
|
No guarantees on when I'd get the remaining issues fixed. @flowerysong feel free to take this back over if you have chance. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ons#540) ec2_eni: minor fix: check if private_ip is provided SUMMARY Add condition to check if private_ip_address is provided before checking if the address is within the subnet's range to avoid failure on tasks without private_ip_address. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_eni ADDITIONAL INFORMATION Few integration tests in other modules such as ec2_instance have tasks that use ec2_eni without a private_ip_address parameter causing it to fail. This check will provide a fix for the bug. Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
|
Abandoning this PR, I've not had chance to pick it back up and we're really lacking in tests for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fixes: #504
When updating the origin on an existing distribution cloudfront returns a "cloudfront list" rather than the list that the code expected. Resulting in a Type error.
See #504 for more details
ISSUE TYPE
COMPONENT NAME
cloudfront_distribution
ADDITIONAL INFORMATION
Initial work by @flowerysong