Fix TypeError caused by giving more than 2 positional arguments to CobblerXMLRPCInterface.get_system_handle() (#10145)

* Update cobbler system module to also use new get_system_handle method definition

* Add changelog for bug fix for cobbler system module

Author: umiruka

changelogs/fragments/10145-fix-typeerror-cobbler-xmlrpc.yml

@@ -0,0 +1,2 @@
+bugfixes:
+  - cobbler_system - fix bug with Cobbler >= 3.4.0 caused by giving more than 2 positional arguments to ``CobblerXMLRPCInterface.get_system_handle()`` (https://github.com/ansible-collections/community.general/issues/8506, https://github.com/ansible-collections/community.general/pull/10145).

plugins/modules/cobbler_system.py

@@ -161,6 +161,8 @@
 from ansible_collections.community.general.plugins.module_utils.datetime import (
     now,
 )
+from ansible_collections.community.general.plugins.module_utils.version import LooseVersion
+
 
 IFPROPS_MAPPING = dict(
     bondingopts='bonding_opts',
@@ -278,7 +280,11 @@ def main():
 
         if system:
             # Update existing entry
-            system_id = conn.get_system_handle(name, token)
+            system_id = None
+            if LooseVersion(str(conn.version())) >= LooseVersion('3.4.0'):
+                system_id = conn.get_system_handle(name)
+            else:
+                system_id = conn.get_system_handle(name, token)
 
             for key, value in iteritems(module.params['properties']):
                 if key not in system: