Applied cosmetic changes

Author: klention

plugins/modules/lvm_pv.py

@@ -13,36 +13,38 @@
 ---
 module: lvm_pv
 short_description: Manage LVM Physical Volumes
-version_added: "1.0.0"
+version_added: "10.7.0"
 description:
-  - Creates, resizes or removes LVM Physical Volumes.
+- Creates, resizes or removes LVM Physical Volumes.
 author:
-  - Klention Mali (@klention)
+- Klention Mali (@klention)
 options:
   device:
     description:
-      - Path to the block device to manage.
+    - Path to the block device to manage.
     type: str
     required: true
   state:
     description:
-      - Control if the physical volume exists.
+    - Control if the physical volume exists.
     type: str
     choices: [ present, absent ]
     default: present
   force:
     description:
-      - Force dangerous operations (equivalent to C(pvcreate -f) or C(pvremove -ff)).
+    - Force the operation.
+    - When O(state=present) (creating a PV), this uses C(pvcreate -f) to force creation.
+    - When O(state=absent) (removing a PV), this uses C(pvremove -ff) to force removal even if part of a volume group.
     type: bool
     default: false
   resize:
     description:
-      - Resize PV to device size when O(state=present).
+    - Resize PV to device size when O(state=present).
     type: bool
     default: false
 notes:
-  - Requires LVM2 utilities installed on the target system.
-  - Device path must exist when creating a PV.
+- Requires LVM2 utilities installed on the target system.
+- Device path must exist when creating a PV.
 '''
 
 EXAMPLES = r'''
@@ -178,26 +180,19 @@ def main():
         if is_pv:
             if module.check_mode:
                 changed = True
-                actions.append('would be removed')
-            else:
-                cmd = ['pvremove']
+                cmd = ['pvremove', '-y']
                 if force:
-                    cmd.extend(['-ff', '-y'])
-                else:
-                    cmd.append('-y')
+                    cmd.append('-ff')
+
                 cmd.append(device)
-                rc, out, err = module.run_command(cmd)
-                if rc != 0:
-                    module.fail_json(msg="Failed to remove PV: %s" % err)
-                changed = True
+                rc, out, err = module.run_command(cmd, check_rc=True)
                 actions.append('removed')
 
     # Generate final message
-    if not actions:
-        msg = "No changes needed for PV %s" % device
-    else:
+    if actions:
         msg = "PV %s: %s" % (device, ', '.join(actions))
-
+    else:
+        msg = "No changes needed for PV %s" % device
     module.exit_json(changed=changed, msg=msg)