Fix tests.

Author: felixfontein

tests/integration/targets/consul/tasks/consul_binding_rule.yml

@@ -33,7 +33,7 @@
     that:
       - result is changed
       - result.binding_rule.AuthMethod == 'test'
-      - result.binding.Description == 'test-binding: my description'
+      - "result.binding_rule.Description == 'test-binding: my description'"
       - result.operation == 'create'
 
 - name: Update a binding rule
@@ -46,7 +46,7 @@
 - assert:
     that:
       - result is changed
-      - result.binding.Description == 'test-binding: my description'
+      - "result.binding_rule.Description == 'test-binding: my description'"
       - result.operation == 'update'
 
 - name: Update a binding rule (noop)
@@ -58,7 +58,7 @@
 - assert:
     that:
       - result is not changed
-      - result.binding.Description == 'test-binding: my description'
+      - "result.binding_rule.Description == 'test-binding: my description'"
       - result.operation is not defined
 
 - name: Delete a binding rule

tests/integration/targets/consul/tasks/consul_token.yml

@@ -22,7 +22,7 @@
 - assert:
     that:
       - simple_create_result is changed
-      - simple_create_result.token.AccessorID
+      - simple_create_result.token.AccessorID is truthy
       - simple_create_result.operation == 'create'
 
 - name: Create token
@@ -84,5 +84,5 @@
 - assert:
     that:
       - result is changed
-      - not result.token
+      - result.token is falsy
       - result.operation == 'remove'

tests/integration/targets/deploy_helper/tasks/main.yml

@@ -123,11 +123,12 @@
   register: releases_path
 - stat: path={{ deploy_helper.shared_path }}
   register: shared_path
+  when: deploy_helper.shared_path is truthy
 - name: Assert State=present with shared_path set to False
   assert:
     that:
     - "releases_path.stat.exists"
-    - "not shared_path.stat.exists"
+    - "deploy_helper.shared_path is falsy or not shared_path.stat.exists"
 
 # Setup older releases for tests
 - file: path={{ deploy_helper.releases_path }}/{{ item }} state=directory

tests/integration/targets/filter_accumulate/tasks/main.yml

@@ -30,6 +30,6 @@
   assert:
     that:
       - integer_result is failed
-      - integer_result.msg is match('Invalid value type.*')
+      - integer_result.msg is search('Invalid value type')
       - non_uniform_list_result is failed
-      - non_uniform_list_result.msg is match('Unexpected templating type error.*can only concatenate str.*')
+      - non_uniform_list_result.msg is search('can only concatenate str')

tests/integration/targets/filter_counter/tasks/main.yml

@@ -26,7 +26,7 @@
   assert:
     that:
       - res is failed
-      - res.msg is match('Argument for community.general.counter must be a sequence')
+      - res.msg is search('Argument for community.general.counter must be a sequence')
 
 - name: test fail element not hashable
   debug:
@@ -38,4 +38,4 @@
   assert:
     that:
       - res is failed
-      - res.msg is match('community.general.counter needs a sequence with hashable elements')
+      - res.msg is search('community.general.counter needs a sequence with hashable elements')

tests/integration/targets/filter_from_csv/tasks/main.yml

@@ -51,4 +51,4 @@
   assert:
     that:
       - _invalid_csv_strict_true is failed
-      - _invalid_csv_strict_true.msg is match('Unable to process file:.*')
+      - _invalid_csv_strict_true.msg is search('Unable to process file:.*')

tests/integration/targets/filter_groupby_as_dict/tasks/main.yml

@@ -16,7 +16,7 @@
 
 - assert:
     that:
-      - result.msg == 'Input is not a sequence'
+      - result.msg is search('Input is not a sequence')
 
 - name: 'Test error: list element not a mapping'
   set_fact:
@@ -26,7 +26,7 @@
 
 - assert:
     that:
-      - "result.msg == 'Sequence element #0 is not a mapping'"
+      - "result.msg is search('Sequence element #0 is not a mapping')"
 
 - name: 'Test error: list element does not have attribute'
   set_fact:
@@ -36,7 +36,7 @@
 
 - assert:
     that:
-      - "result.msg == 'Attribute not contained in element #1 of sequence'"
+      - "result.msg is search('Attribute not contained in element #1 of sequence')"
 
 - name: 'Test error: attribute collision'
   set_fact:
@@ -46,4 +46,4 @@
 
 - assert:
     that:
-      - result.msg == "Multiple sequence entries have attribute value 'a'" or result.msg == "Multiple sequence entries have attribute value u'a'"
+      - result.msg is search("Multiple sequence entries have attribute value u?'a'")

tests/integration/targets/filter_hashids/tasks/main.yml

@@ -31,7 +31,7 @@
 
 - name: Register result of invalid salt
   debug:
-    var: "invalid_input | community.general.hashids_encode(salt=10)"
+    var: "single_int | community.general.hashids_encode(salt=10)"
   register: invalid_salt_message
   ignore_errors: true
 
@@ -42,7 +42,7 @@
 
 - name: Register result of invalid alphabet
   debug:
-    var: "invalid_input | community.general.hashids_encode(alphabet='abc')"
+    var: "single_int | community.general.hashids_encode(alphabet='abc')"
   register: invalid_alphabet_message
   ignore_errors: true
 
@@ -53,7 +53,7 @@
 
 - name: Register result of invalid min_length
   debug:
-    var: "invalid_input | community.general.hashids_encode(min_length='foo')"
+    var: "single_int | community.general.hashids_encode(min_length='foo')"
   register: invalid_min_length_message
   ignore_errors: true
 

tests/integration/targets/filter_keep_keys/tasks/tests.yml

@@ -6,7 +6,7 @@
 - name: Debug ansible_version
   ansible.builtin.debug:
     var: ansible_version
-  when: not quite_test | d(true) | bool
+  when: not (quiet_test | default(true) | bool)
   tags: ansible_version
 
 - name: Tests
@@ -19,13 +19,13 @@
     fail_msg: |
       [ERR] result:
       {{ result | to_yaml }}
-    quiet: "{{ quiet_test | d(true) | bool }}"
+    quiet: "{{ quiet_test | default(true) | bool }}"
   loop: "{{ tests | subelements('group') }}"
   loop_control:
     loop_var: i
-    label: "{{ i.1.mp | d('default') }}: {{ i.1.tt }}"
+    label: "{{ i.1.mp | default('default') }}: {{ i.1.tt }}"
   vars:
     input: "{{ i.0.input }}"
     target: "{{ i.1.tt }}"
-    mp: "{{ i.1.mp | d('default') }}"
+    mp: "{{ i.1.mp | default('default') }}"
     result: "{{ lookup('template', i.0.template) }}"

tests/integration/targets/filter_random_mac/tasks/main.yml

@@ -19,7 +19,7 @@
   assert:
     that:
       - _bad_random_mac_filter is failed
-      - "_bad_random_mac_filter.msg is match('Invalid value type (.*int.*) for random_mac .*')"
+      - "_bad_random_mac_filter.msg is search('Invalid value type (.*int.*) for random_mac .*')"
 
 - name: Test random_mac filter bad argument value
   debug:
@@ -31,7 +31,7 @@
   assert:
     that:
       - _bad_random_mac_filter is failed
-      - "_bad_random_mac_filter.msg is match('Invalid value (.*) for random_mac: .* not hexa byte')"
+      - "_bad_random_mac_filter.msg is search('Invalid value (.*) for random_mac: .* not hexa byte')"
 
 - name: Test random_mac filter prefix too big
   debug:
@@ -43,7 +43,7 @@
   assert:
     that:
       - _bad_random_mac_filter is failed
-      - "_bad_random_mac_filter.msg is match('Invalid value (.*) for random_mac: 5 colon.* separated items max')"
+      - "_bad_random_mac_filter.msg is search('Invalid value (.*) for random_mac: 5 colon.* separated items max')"
 
 - name:  Verify random_mac filter
   assert:

tests/integration/targets/filter_remove_keys/tasks/tests.yml

@@ -6,7 +6,7 @@
 - name: Debug ansible_version
   ansible.builtin.debug:
     var: ansible_version
-  when: not quite_test | d(true) | bool
+  when: not (quiet_test | default(true) | bool)
   tags: ansible_version
 
 - name: Tests
@@ -19,13 +19,13 @@
     fail_msg: |
       [ERR] result:
       {{ result | to_yaml }}
-    quiet: "{{ quiet_test | d(true) | bool }}"
+    quiet: "{{ quiet_test | default(true) | bool }}"
   loop: "{{ tests | subelements('group') }}"
   loop_control:
     loop_var: i
-    label: "{{ i.1.mp | d('default') }}: {{ i.1.tt }}"
+    label: "{{ i.1.mp | default('default') }}: {{ i.1.tt }}"
   vars:
     input: "{{ i.0.input }}"
     target: "{{ i.1.tt }}"
-    mp: "{{ i.1.mp | d('default') }}"
+    mp: "{{ i.1.mp | default('default') }}"
     result: "{{ lookup('template', i.0.template) }}"

tests/integration/targets/filter_replace_keys/tasks/tests.yml

@@ -6,7 +6,7 @@
 - name: Debug ansible_version
   ansible.builtin.debug:
     var: ansible_version
-  when: not quite_test | d(true) | bool
+  when: not (quiet_test | default(true) | bool)
   tags: ansible_version
 
 - name: Tests
@@ -19,13 +19,13 @@
     fail_msg: |
       [ERR] result:
       {{ result | to_yaml }}
-    quiet: "{{ quiet_test | d(true) | bool }}"
+    quiet: "{{ quiet_test | default(true) | bool }}"
   loop: "{{ tests | subelements('group') }}"
   loop_control:
     loop_var: i
-    label: "{{ i.1.mp | d('default') }}: {{ i.1.tt }}"
+    label: "{{ i.1.mp | default('default') }}: {{ i.1.tt }}"
   vars:
     input: "{{ i.0.input }}"
     target: "{{ i.1.tt }}"
-    mp: "{{ i.1.mp | d('default') }}"
+    mp: "{{ i.1.mp | default('default') }}"
     result: "{{ lookup('template', i.0.template) }}"

tests/integration/targets/kernel_blacklist/tasks/main.yml

@@ -51,7 +51,7 @@
       - orig_stat.stat.size == stat_test_1.stat.size
       - orig_stat.stat.checksum == stat_test_1.stat.checksum
       - orig_stat.stat.mtime == stat_test_1.stat.mtime
-      - stat_test_1.stat.checksum == expected_content | checksum
+      - stat_test_1.stat.checksum == (expected_content | trim + '\n') | checksum
   vars:
     expected_content: |
       # Copyright (c) Ansible Project
@@ -83,7 +83,7 @@
   assert:
     that:
       - bl_test_2 is changed
-      - slurp_test_2.content|b64decode == content
+      - slurp_test_2.content|b64decode == (content | trim + '\n')
   vars:
     content: |
       # Copyright (c) Ansible Project
@@ -111,7 +111,7 @@
   assert:
     that:
       - bl_test_3 is changed
-      - slurp_test_3.content|b64decode == content
+      - slurp_test_3.content|b64decode == (content | trim + '\n')
   vars:
     content: |
       # Copyright (c) Ansible Project

tests/integration/targets/keycloak_realm_key/tasks/main.yml

@@ -151,7 +151,8 @@
       - result.end_state.config.enabled == ["true"]
       - result.end_state.config.algorithm == ["RS256"]
       - result.end_state.config.priority == ["140"]
-      - result.msg == "Realm key testkey would be changed: config.priority ['150'] -> ['140']"
+      - >-
+        result.msg == "Realm key testkey would be changed: config.priority ['150'] -> ['140']"
 
 - name: Update custom realm key
   community.general.keycloak_realm_key:
@@ -184,7 +185,8 @@
       - result.end_state.config.enabled == ["true"]
       - result.end_state.config.algorithm == ["RS256"]
       - result.end_state.config.priority == ["140"]
-      - result.msg == "Realm key testkey changed: config.priority ['150'] -> ['140']"
+      - >-
+        result.msg == "Realm key testkey changed: config.priority ['150'] -> ['140']"
 
 - name: Update custom realm key (test for idempotency)
   community.general.keycloak_realm_key:

tests/integration/targets/setup_cron/tasks/main.yml

@@ -25,10 +25,10 @@
   - name: install cron package
     package:
       name: '{{ cron_pkg }}'
-    when: cron_pkg | default(false, true)
+    when: (cron_pkg | default(false, true)) is truthy
     register: cron_package_installed
     until: cron_package_installed is success
-  - when: faketime_pkg | default(false, true)
+  - when: (faketime_pkg | default(false, true)) is truthy
     block:
     - name: install cron and faketime packages
       package: