Remove deprecated features and plugins for 11.0.0 (#10126)

* Bump version to 11.0.0.

* Removed deprecated plugins/modules.

* Remove _init_session().

* Remove ack_venv_creation_deprecation.

* Change behavior of state.

* Remove value reading.

* Remove list_all.

* Remove various deprecated module helper things.

* Change default of proxmox's update parameter.

* Fix constructor command order.

Co-authored-by: Alexei Znamensky <[email protected]>

* MH: adjust guide

---------

Co-authored-by: Alexei Znamensky <[email protected]>
Co-authored-by: Alexei Znamensky <[email protected]>

Author: felixfontein

.github/BOTMETA.yml

@@ -127,8 +127,6 @@ files:
     maintainers: $team_ansible_core
   $doc_fragments/:
     labels: docs_fragments
-  $doc_fragments/clc.py:
-    maintainers: clc-runner russoz
   $doc_fragments/django.py:
     maintainers: russoz
   $doc_fragments/hpe3par.py:
@@ -254,8 +252,6 @@ files:
   $inventories/scaleway.py:
     labels: cloud scaleway
     maintainers: $team_scaleway
-  $inventories/stackpath_compute.py:
-    maintainers: shayrybak
   $inventories/virtualbox.py: {}
   $inventories/xen_orchestra.py:
     maintainers: ddelnano shinuza
@@ -299,9 +295,6 @@ files:
   $lookups/lastpass.py: {}
   $lookups/lmdb_kv.py:
     maintainers: jpmens
-  $lookups/manifold.py:
-    labels: manifold
-    maintainers: galanoff
   $lookups/merge_variables.py:
     maintainers: rlenferink m-a-r-k-e alpex8
   $lookups/onepass:
@@ -510,8 +503,6 @@ files:
     maintainers: NickatEpic
   $modules/cisco_webex.py:
     maintainers: drew-russell
-  $modules/clc_:
-    maintainers: clc-runner
   $modules/cloud_init_data_facts.py:
     maintainers: resmo
   $modules/cloudflare_dns.py:
@@ -670,8 +661,6 @@ files:
     maintainers: marns93
   $modules/hg.py:
     maintainers: yeukhon
-  $modules/hipchat.py:
-    maintainers: pb8226 shirou
   $modules/homebrew.py:
     ignore: ryansb
     keywords: brew cask darwin homebrew macosx macports osx
@@ -1145,8 +1134,6 @@ files:
     maintainers: $team_bsd berenddeboer
   $modules/pritunl_:
     maintainers: Lowess
-  $modules/profitbricks:
-    maintainers: baldwinSPC
   $modules/proxmox:
     keywords: kvm libvirt proxmox qemu
     labels: proxmox virt

changelogs/fragments/deprecations.yml

@@ -0,0 +1,19 @@
+removed_features:
+  - "stackpath_compute inventory plugin - the plugin was removed since the company and the service were sunset in June 2024 (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "manifold lookup plugin - the plugin was removed since the company was acquired in 2021 and service was ceased afterwards (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "clc_* modules and doc fragment - the modules were removed since CenturyLink Cloud services went EOL in September 2023 (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "hipchat - the module was removed since the hipchat service has been discontinued and the self-hosted variant has been End of Life since 2020 (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "profitbrick* modules - the modules were removed since the supporting library is unsupported since 2021 (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "redfish_utils module utils - the ``_init_session`` method has been removed (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "django_manage - the ``ack_venv_creation_deprecation`` option has been removed. It had no effect anymore anyway (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "apt_rpm - the ``present`` and ``installed`` states are no longer equivalent to ``latest``, but to ``present_not_latest`` (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "git_config - it is no longer allowed to use ``state=present`` with no value to read the config value. Use the ``community.general.git_config_info`` module instead (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "git_config - the ``list_all`` option has been removed. Use the ``community.general.git_config_info`` module instead (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "mh.mixins.deps module utils - this module utils has been removed. Use the ``deps`` module utils instead (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "mh.mixins.vars module utils - this module utils has been removed. Use ``VarDict`` from the ``vardict`` module utils instead (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "mh.module_helper module utils - ``VarDict`` is now imported from the ``vardict`` module utils and no longer from the removed ``mh.mixins.vars`` module utils (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "mh.module_helper module utils - ``AnsibleModule`` and ``VarsMixin`` are no longer provided (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "mh.module_helper module utils - the attributes ``use_old_vardict`` and ``mute_vardict_deprecation`` from ``ModuleHelper`` have been removed. We suggest to remove them from your modules if you no longer support community.general < 11.0.0 (https://github.com/ansible-collections/community.general/pull/10126)."
+  - "module_helper module utils - ``StateMixin``, ``DependencyCtxMgr``, ``VarMeta``, ``VarDict``, and ``VarsMixin`` are no longer provided (https://github.com/ansible-collections/community.general/pull/10126)."
+breaking_changes:
+  - "proxmox - the default of ``update`` changed from ``false`` to ``true`` (https://github.com/ansible-collections/community.general/pull/10126)."

docs/docsite/rst/guide_modulehelper.rst

@@ -38,7 +38,6 @@ But bear in mind that it does not showcase all of MH's features:
             ),
             supports_check_mode=True,
         )
-        use_old_vardict = False
 
         def __run__(self):
             self.vars.original_message = ''
@@ -84,10 +83,6 @@ section above, but there are more elements that will take part in it.
 
         facts_name = None   # used if generating facts, from parameters or otherwise
 
-        # transitional variables for the new VarDict implementation, see information below
-        use_old_vardict = True
-        mute_vardict_deprecation = False
-
         module = dict(
             argument_spec=dict(...),
             # ...
@@ -207,28 +202,14 @@ By using ``self.vars``, you get a central mechanism to access the parameters but
 As described in :ref:`ansible_collections.community.general.docsite.guide_vardict`, variables in ``VarDict`` have metadata associated to them.
 One of the attributes in that metadata marks the variable for output, and MH makes use of that to generate the module's return values.
 
-.. important::
-
-    The ``VarDict`` feature described was introduced in community.general 7.1.0, but there was a first
-    implementation of it embedded within ``ModuleHelper``.
-    That older implementation is now deprecated and will be removed in community.general 11.0.0.
-    After community.general 7.1.0, MH modules generate a deprecation message about *using the old VarDict*.
-    There are two ways to prevent that from happening:
-
-        #.  Set ``mute_vardict_deprecation = True`` and the deprecation will be silenced. If the module still uses the old ``VarDict``,
-            it will not be able to update to community.general 11.0.0 (Spring 2025) upon its release.
-        #.  Set ``use_old_vardict = False`` to make the MH module use the new ``VarDict`` immediately.
-            We strongly recommend you use the new ``VarDict``, for that you make sure to consult its documentation at
-            :ref:`ansible_collections.community.general.docsite.guide_vardict`.
-
-    .. code-block:: python
+.. note::
 
-        class MyTest(ModuleHelper):
-            use_old_vardict = False
-            mute_vardict_deprecation = True
-            ...
+    The ``VarDict`` class was introduced in community.general 7.1.0, as part of ``ModuleHelper`` itself.
+    However, it has been factored out to become an utility on its own, described in :ref:`ansible_collections.community.general.docsite.guide_vardict`,
+    and the older implementation was removed in community.general 11.0.0.
 
-    These two settings are mutually exclusive, but that is not enforced and the behavior when setting both is not specified.
+    Some code might still refer to the class variables ``use_old_vardict`` and ``mute_vardict_deprecation``, used for the transtition to the new
+    implementation but from community.general 11.0.0 onwards they are no longer used and can be safely removed from the code.
 
 Contrary to new variables created in ``VarDict``, module parameters are not set for output by default.
 If you want to include some module parameters in the output, list them in the ``output_params`` class variable.
@@ -410,7 +391,6 @@ By using ``StateModuleHelper`` you can make your code like the excerpt from the
         module = dict(
             ...
         )
-        use_old_vardict = False
 
         def __init_module__(self):
             self.runner = gconftool2_runner(self.module, check_rc=True)

galaxy.yml

@@ -5,7 +5,7 @@
 
 namespace: community
 name: general
-version: 10.7.0
+version: 11.0.0
 readme: README.md
 authors:
   - Ansible (https://github.com/ansible)

meta/runtime.yml

@@ -100,7 +100,7 @@ plugin_routing:
     hashi_vault:
       redirect: community.hashi_vault.hashi_vault
     manifold:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: Company was acquired in 2021 and service was ceased afterwards.
     nios:
@@ -129,39 +129,39 @@ plugin_routing:
     cisco_spark:
       redirect: community.general.cisco_webex
     clc_alert_policy:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_blueprint_package:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_firewall_policy:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_group:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_loadbalancer:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_modify_server:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_publicip:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_server:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     clc_server_snapshot:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: CenturyLink Cloud services went EOL in September 2023.
     consul_acl:
@@ -320,7 +320,7 @@ plugin_routing:
     hetzner_firewall_info:
       redirect: community.hrobot.firewall_info
     hipchat:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: The hipchat service has been discontinued and the self-hosted variant has been End of Life since 2020.
     hpilo_facts:
@@ -645,23 +645,23 @@ plugin_routing:
     postgresql_user_obj_stat_info:
       redirect: community.postgresql.postgresql_user_obj_stat_info
     profitbricks:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: Supporting library is unsupported since 2021.
     profitbricks_datacenter:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: Supporting library is unsupported since 2021.
     profitbricks_nic:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: Supporting library is unsupported since 2021.
     profitbricks_volume:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: Supporting library is unsupported since 2021.
     profitbricks_volume_attachments:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: Supporting library is unsupported since 2021.
     purefa_facts:
@@ -970,7 +970,7 @@ plugin_routing:
     kubevirt:
       redirect: community.kubevirt.kubevirt
     stackpath_compute:
-      deprecation:
+      tombstone:
         removal_version: 11.0.0
         warning_text: The company and the service were sunset in June 2024.
   filter: