Skip to content

Commit 8253e8f

Browse files
authored
style: fix ruff rule PLW0603 (#366)
1 parent a6d3610 commit 8253e8f

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

plugins/modules/proxmox_kvm.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,8 +1113,6 @@ def module_options():
11131113

11141114
class ProxmoxKvmAnsible(ProxmoxAnsible):
11151115
def get_vminfo(self, node, vmid, **kwargs):
1116-
global results
1117-
results = {}
11181116
mac = {}
11191117
devices = {}
11201118
try:
@@ -1141,9 +1139,7 @@ def get_vminfo(self, node, vmid, **kwargs):
11411139
elif re_dev.match(k):
11421140
devices[k] = parse_dev(vm[k])
11431141

1144-
results["mac"] = mac
1145-
results["devices"] = devices
1146-
results["vmid"] = int(vmid)
1142+
return {"mac": mac, "devices": devices, "vmid": int(vmid)}
11471143

11481144
def settings(self, vmid, node, **kwargs):
11491145
proxmox_node = self.proxmox_api.nodes(node)
@@ -1519,6 +1515,7 @@ def main():
15191515
elif not proxmox.get_node(node):
15201516
module.fail_json(msg=f"node '{node}' does not exist in cluster")
15211517

1518+
vminfo = {}
15221519
try:
15231520
proxmox.create_vm(
15241521
vmid,
@@ -1603,7 +1600,7 @@ def main():
16031600
)
16041601

16051602
if not clone:
1606-
proxmox.get_vminfo(
1603+
vminfo = proxmox.get_vminfo(
16071604
node,
16081605
vmid,
16091606
ide=module.params["ide"],
@@ -1629,7 +1626,7 @@ def main():
16291626
changed=True, vmid=newid, msg=f"VM {name} with newid {newid} cloned from vm with vmid {vmid}"
16301627
)
16311628
else:
1632-
module.exit_json(changed=True, msg=f"VM {name} with vmid {vmid} deployed", **results)
1629+
module.exit_json(changed=True, msg=f"VM {name} with vmid {vmid} deployed", **vminfo)
16331630

16341631
elif state == "started":
16351632
if not vmid:

0 commit comments

Comments
 (0)