Fix integration tests for 2.19

Author: mariolenz

tests/integration/targets/vmware_cluster_info/tasks/main.yml

@@ -19,7 +19,7 @@
   name: ensure info are gathered for all clusters
   assert:
     that:
-        - all_cluster_result.clusters
+        - all_cluster_result.clusters | length > 0
         - not all_cluster_result.changed
 
 - name: ensure info are all defined
@@ -72,7 +72,7 @@
   name: Ensure info are gathered for the given cluster
   assert:
     that:
-        - cluster_result.clusters
+        - cluster_result.clusters | length > 0
         - not cluster_result.changed
 
 - <<: *vc_cluster_data
@@ -99,7 +99,7 @@
 - name: Ensure info are gathered for all clusters with properteis
   assert:
     that:
-      - all_cluster_result.clusters
+      - all_cluster_result.clusters | length > 0
       - all_cluster_result.clusters[item].name == item
       - all_cluster_result.clusters[item].configuration.dasConfig.enabled is defined
       - all_cluster_result.clusters[item].summary.totalCpu is defined
@@ -123,7 +123,7 @@
 - name: Ensure info are gathered for the given cluster with properties
   assert:
     that:
-      - cluster_result.clusters
+      - cluster_result.clusters | length > 0
       - cluster_result.clusters[item].name == item
       - cluster_result.clusters[item].configuration.dasConfig.enabled is defined
       - cluster_result.clusters[item].summary.totalCpu is defined
@@ -191,4 +191,4 @@
 - name: "Ensure URL-encoded cluster name"
   assert:
     that:
-      - all_cluster_result.clusters['Cluster/\%']
+      - all_cluster_result.clusters['Cluster/\%'] is truthy

tests/integration/targets/vmware_datacenter_info/tasks/main.yml

@@ -19,7 +19,7 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0
 
 - name: Gather information about all datacenter in check mode
   vmware_datacenter_info:
@@ -36,7 +36,7 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0
 
 - name: Gather information about particular datacenter
   vmware_datacenter_info:
@@ -53,7 +53,7 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0
 
 - name: Gather information about particular datacenter in check mode
   vmware_datacenter_info:
@@ -71,4 +71,4 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0

tests/integration/targets/vmware_dvs_portgroup_info/tasks/main.yml

@@ -64,7 +64,7 @@
       assert:
         that:
           - >-
-           dvs_results.dvs_portgroup_info.{{ dvswitch1 }}
+           dvs_results.dvs_portgroup_info['{{ dvswitch1 }}']
            | map(attribute='portgroup_name')
            | select('==', 'dvportgroup\/%')
            | list
@@ -107,4 +107,4 @@
 - assert:
     that:
       - "dvs_results_0002['dvs_portgroup_info']['DVS0'] is defined"
-      - dvs_results_0002['dvs_portgroup_info']['DVS0'][0].key
+      - dvs_results_0002['dvs_portgroup_info']['DVS0'][0].key is truthy

tests/integration/targets/vmware_guest_controller/tasks/main.yml

@@ -15,7 +15,7 @@
     hostname: "{{ vcenter_hostname }}"
     username: "{{ vcenter_username }}"
     password: "{{ vcenter_password }}"
-    name: "{{ virtual_machines[0].name }}"
+    name: "{{ virtual_machines.0.name }}"
     gather_disk_controller_facts: true
   register: disk_controller_facts