Fix ansible-core 2.19 compatibility

Author: mariolenz

changelogs/fragments/2391-core-2.19.compatibility.yml

@@ -0,0 +1,3 @@
+bugfixes:
+  - vmware_guest_controller - Fix an issue with ansible-core 2.19
+    (https://github.com/ansible-collections/community.vmware/pull/2391).

plugins/modules/vmware_guest_controller.py

@@ -345,7 +345,7 @@ def gather_disk_controller_facts(self):
         for device in self.current_vm_obj.config.hardware.device:
             ctl_facts_dict = dict()
             if isinstance(device, tuple(self.controller_types.values())):
-                ctl_facts_dict[device.busNumber] = dict(
+                ctl_facts_dict[str(device.busNumber)] = dict(
                     controller_summary=device.deviceInfo.summary,
                     controller_label=device.deviceInfo.label,
                     controller_busnumber=device.busNumber,
@@ -355,7 +355,7 @@ def gather_disk_controller_facts(self):
                     controller_disks_devicekey=device.device,
                 )
                 if hasattr(device, 'sharedBus'):
-                    ctl_facts_dict[device.busNumber]['controller_bus_sharing'] = device.sharedBus
+                    ctl_facts_dict[str(device.busNumber)]['controller_bus_sharing'] = device.sharedBus
                 if isinstance(device, tuple(self.device_helper.scsi_device_type.values())):
                     disk_ctl_facts['scsi'].update(ctl_facts_dict)
                 if isinstance(device, self.device_helper.nvme_device_type):

tests/integration/targets/vmware_cluster_info/tasks/main.yml

@@ -19,7 +19,7 @@
   name: ensure info are gathered for all clusters
   assert:
     that:
-        - all_cluster_result.clusters
+        - all_cluster_result.clusters | length > 0
         - not all_cluster_result.changed
 
 - name: ensure info are all defined
@@ -72,7 +72,7 @@
   name: Ensure info are gathered for the given cluster
   assert:
     that:
-        - cluster_result.clusters
+        - cluster_result.clusters | length > 0
         - not cluster_result.changed
 
 - <<: *vc_cluster_data
@@ -99,7 +99,7 @@
 - name: Ensure info are gathered for all clusters with properteis
   assert:
     that:
-      - all_cluster_result.clusters
+      - all_cluster_result.clusters | length > 0
       - all_cluster_result.clusters[item].name == item
       - all_cluster_result.clusters[item].configuration.dasConfig.enabled is defined
       - all_cluster_result.clusters[item].summary.totalCpu is defined
@@ -123,7 +123,7 @@
 - name: Ensure info are gathered for the given cluster with properties
   assert:
     that:
-      - cluster_result.clusters
+      - cluster_result.clusters | length > 0
       - cluster_result.clusters[item].name == item
       - cluster_result.clusters[item].configuration.dasConfig.enabled is defined
       - cluster_result.clusters[item].summary.totalCpu is defined
@@ -191,4 +191,4 @@
 - name: "Ensure URL-encoded cluster name"
   assert:
     that:
-      - all_cluster_result.clusters['Cluster/\%']
+      - all_cluster_result.clusters['Cluster/\%'] is truthy

tests/integration/targets/vmware_datacenter_info/tasks/main.yml

@@ -19,7 +19,7 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0
 
 - name: Gather information about all datacenter in check mode
   vmware_datacenter_info:
@@ -36,7 +36,7 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0
 
 - name: Gather information about particular datacenter
   vmware_datacenter_info:
@@ -53,7 +53,7 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0
 
 - name: Gather information about particular datacenter in check mode
   vmware_datacenter_info:
@@ -71,4 +71,4 @@
 - name: Ensure datacenter is present
   assert:
     that:
-        - dc_result.datacenter_info
+        - dc_result.datacenter_info | length > 0

tests/integration/targets/vmware_dvs_portgroup_info/tasks/main.yml

@@ -64,7 +64,7 @@
       assert:
         that:
           - >-
-           dvs_results.dvs_portgroup_info.{{ dvswitch1 }}
+           dvs_results.dvs_portgroup_info['{{ dvswitch1 }}']
            | map(attribute='portgroup_name')
            | select('==', 'dvportgroup\/%')
            | list
@@ -107,4 +107,4 @@
 - assert:
     that:
       - "dvs_results_0002['dvs_portgroup_info']['DVS0'] is defined"
-      - dvs_results_0002['dvs_portgroup_info']['DVS0'][0].key
+      - dvs_results_0002['dvs_portgroup_info']['DVS0'][0].key is truthy

tests/integration/targets/vmware_guest_boot_manager/tasks/main.yml

@@ -75,6 +75,10 @@
         that:
         - boot_info2.vm_boot_info.current_secure_boot_enabled is true
 
+- name: Debug VMs
+  debug:
+    var: virtual_machines
+
 - name: Get VM disk info 1
   community.vmware.vmware_guest_disk_info:
     validate_certs: false