Getting the full path and using a different condition to fix issue. #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a new function instead of an old block of code. Rewritten condition for getting a vm_obj.
Krioks
force-pushed
the
#1090_correctly_getting_the_folder_name
branch
from
5c629fa to
24e7a5c
Compare
|
recheck |
|
There hasn't been any activity on this PR for quite some time, so I'll close it for now. Feel free to re-open it or open a new one if you think it's important. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1090 when creating / deleting a VM with vmware_guest it could be created/deleted in an another folder.
As mentioned in this issue, the fix was to compare VM paths correctly.
ISSUE TYPE
COMPONENT NAME
vmware_guest causes an issue when creating / deleting a VM in folder with similar name, e.g. :
└───Project
├───aaa1
├───aaa111
│ test1
└───aaa1111
When I want to create a virtual machine with name test1 in the aaa1 folder, the virtual machine is created (customized) in the aaa111 folder, instead of the aaa1 folder. And, when I try to delete the test1 machine from the aaa1 folder, I will delete it from the aaa111 folder.