Cross VC Clone does not work with Datacenters in Folders

[romulus-ai]

SUMMARY

We try an cross VC clone and in Dest vCenter the Datacenters are organized in Folders. However Cross VC Clone seems to not find the destination folder for that reason it seems.

ISSUE TYPE

• Bug Report

COMPONENT NAME

community.vmware.vmware_guest_cross_vc_clone

ANSIBLE VERSION

ansible [core 2.13.5]
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /root/.local/lib/python3.10/site-packages/ansible
  ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
  executable location = /root/.local/bin/ansible
  python version = 3.10.6 (main, Aug 10 2022, 11:40:04) [GCC 11.3.0]
  jinja version = 3.1.2
  libyaml = True

COLLECTION VERSION

-->

community.vmware        3.0.0  

CONFIGURATION

nothing changed, default configuration

OS / ENVIRONMENT

Source vCenter:
Version 7.0.3 Build 20150588
Sourcepath of VM: /DC/vm/Templates

Dest vCenter:
Version 7.0.3 Build 20150588
Destpath for VM: /DE/DC/vm/Templates

/DE is just a folder, DC is the Datacenter.

STEPS TO REPRODUCE

Just trying to clone a VM from one VC zu another VC, pretty close to the examples from documentation, the VM should be converted to a template afterwards.

- name: clone a template across VC
      community.vmware.vmware_guest_cross_vc_clone:
        hostname: "{{ vmware_hostname }}"
        username: "{{ vmware_username }}"
        password: "{{ vmware_password }}"
        validate_certs: false
        moid: "{{ image_facts.virtual_machines[0].moid }}"
        destination_vm_name: "{{ image_facts.virtual_machines[0].guest_name }}"
        destination_vcenter: "destvc.example.com"
        destination_vcenter_username: "{{ vmware_username }}"
        destination_vcenter_password: "{{ vmware_password }}"
        destination_vcenter_validate_certs: false
        destination_host: desthost.de.example.com
        destination_datastore: "Datastore 1"
        destination_vm_folder: "/DE/DC/vm/Templates"
        is_template: true
        state: present

EXPECTED RESULTS

I expect that the VM will be cloned.

ACTUAL RESULTS

Fully Verbose output will follow, its still running currently, since this affects a quiet long running pipeline.

msg: Destination folder does not exist. Please refer to the documentation to correctly specify the folder.

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[romulus-ai]

Here the "Actual Results" with -vvvv option:

TASK [clone a vm across VC] **********************************************
    task path: /builds/it/automatisation/vsphere-images/image-finalization/play.yaml:41
    <127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: root
    <127.0.0.1> EXEC /bin/sh -c 'echo ~root && sleep 0'
    <127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470 `" && echo ansible-tmp-1665645313.8767822-409-260904906207470="` echo /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470 `" ) && sleep 0'
    Using module file /root/.ansible/collections/ansible_collections/community/vmware/plugins/modules/vmware_guest_cross_vc_clone.py
    <127.0.0.1> PUT /root/.ansible/tmp/ansible-local-304dyqxej42/tmpftedw5ua TO /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470/AnsiballZ_vmware_guest_cross_vc_clone.py
    <127.0.0.1> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470/ /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470/AnsiballZ_vmware_guest_cross_vc_clone.py && sleep 0'
    <127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3 /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470/AnsiballZ_vmware_guest_cross_vc_clone.py && sleep 0'
    <127.0.0.1> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1665645313.8767822-409-260904906207470/ > /dev/null 2>&1 && sleep 0'
    fatal: [127.0.0.1]: FAILED! => changed=false 
      invocation:
        module_args:
          destination_datastore: 'Datastore 1'
          destination_host: desthost.de.example.com
          destination_resource_pool: null
          destination_vcenter: destvc.example.com
          destination_vcenter_password: VALUE_SPECIFIED_IN_NO_LOG_PARAMETER
          destination_vcenter_port: 443
          destination_vcenter_username: user@example.com
          destination_vcenter_validate_certs: false
          destination_vm_folder: /DE/DC/vm/Templates
          destination_vm_name: packer-ubuntu-2004-standard
          hostname: srcvc.example.com
          is_template: true
          moid: vm-45957
          name: null
          password: VALUE_SPECIFIED_IN_NO_LOG_PARAMETER
          port: 443
          proxy_host: null
          proxy_port: null
          state: present
          use_instance_uuid: false
          username: user@example.com
          uuid: null
          validate_certs: false
      msg: Destination folder does not exist. Please refer to the documentation to correctly specify the folder.

[romulus-ai]

It seems it if working fine, however, since the get_obj_by_name function fetches all folder objects in vcenter and tries to match only the folder name not the path, you have just to define the folder name without the path to the folder.

i.e. instead of "/DE/DC1/vm/templates" you should only define it like "templates". No Idea how the behaviour is if you have multiple folders called "templates"

Additionally there is another problem with ssl validation. Since the "serviceLocatorSpec" in "CloneSpec" does not support "ignoreSSL", you have to inject the correct thumbprint here if you want a real working ignore SSL mode. Here I am also builting a patch currently.

[Hentheroot]

Yh I'm running in this too. Waiting for the patch.

[Hentheroot]

I tried and when you have multiple folders with the same name it fails. It has to be unique...

[romulus-ai]

Good to know, seems we have an issue here too.