Allow storage vmotion to change disk type

[aspeer06]

SUMMARY

Allow a storage vmotion to modify the disk type. This would help alleviate fallout from the thicklazyzero bug.
ansible version: 2.9.18

ISSUE TYPE

Modify community.vmware.vmware_vmotion to accept a disk provisioning type of thin, thick, or thickeagerzeroed

COMPONENT NAME

vmware_vmotion.py

ADDITIONAL INFORMATION

It would be nice to be able to script changing thin disks to thick or vice versa after the fact using ansible instead of spawning off to a mess of powercli

- name: Perform storage vMotion of of virtual machine
  community.vmware.vmware_vmotion:
    hostname: '{{ vcenter_hostname }}'
    username: '{{ vcenter_username }}'
    password: '{{ vcenter_password }}'
    vm_name: 'vm_name_as_per_vcenter'
    destination_datastore: 'destination_datastore_as_per_vcenter'
    type: thickeagerzeroed
  delegate_to: localhost

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

@aspeer06: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

• ansible version

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

[ansibullbot]

Files identified in the description:

• [plugins/modules/vmware_vmotion.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/vmware_vmotion.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Akasurde @Tomorrow9 @bedecarroll @goneri @lparkes @oboukili @pgbidkar @warthog9
click here for bot help

[lebonez]

There are only two options that I can see for this.
First is to specify destination_disk_type (requiring destination_datastore set as well) that applies the user specified type to every disk on the VM. This is not ideal since some VMs might have multiple disk i.e. swap, bulk, and OS where they might not want all disks moved to the same type and datastore. This doesn't change current functionality much at all since we currently just move every disk to the same destination_datastore.

Second is to specify parameters on a per disk basis mirroring a lot of the same functionality as vmware_guest_disk using options available from RelocateSpec, DiskLocator and VirtualDisk.FlatVer2BackingInfo. We'd have to decide whether we keep the current functionality though where we can specify blanket options like destination_datastore. Might be better to do this in a new module as well.

I prefer the first option for this specific module though it would be nice to have some new module like the second option.