Skip to content

Commit a41db7d

Browse files
committed
review comments
1 parent 6498a34 commit a41db7d

File tree

3 files changed

+33
-12
lines changed

3 files changed

+33
-12
lines changed

roles/support_mode/defaults/main.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
# Copyright (c) IBM Corporation 2020, 2025
2+
# Licensed under the Apache License, Version 2.0 (the "License");
3+
# you may not use this file except in compliance with the License.
4+
# You may obtain a copy of the License at
5+
# http://www.apache.org/licenses/LICENSE-2.0
6+
# Unless required by applicable law or agreed to in writing, software
7+
# distributed under the License is distributed on an "AS IS" BASIS,
8+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
9+
# See the License for the specific language governing permissions and
10+
# limitations under the License.
111
---
212
# Operator PCON command
313
support_mode_gather_syslog: false

roles/support_mode/tasks/main.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
# Copyright (c) IBM Corporation 2020, 2025
2+
# Licensed under the Apache License, Version 2.0 (the "License");
3+
# you may not use this file except in compliance with the License.
4+
# You may obtain a copy of the License at
5+
# http://www.apache.org/licenses/LICENSE-2.0
6+
# Unless required by applicable law or agreed to in writing, software
7+
# distributed under the License is distributed on an "AS IS" BASIS,
8+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
9+
# See the License for the specific language governing permissions and
10+
# limitations under the License.
111
---
212
- name: Include z/OS managed node diagnostic tasks
313
ansible.builtin.include_tasks: zos_managed.yml

roles/support_mode/tasks/zos_managed.yml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
# Copyright (c) IBM Corporation 2020, 2025
2+
# Licensed under the Apache License, Version 2.0 (the "License");
3+
# you may not use this file except in compliance with the License.
4+
# You may obtain a copy of the License at
5+
# http://www.apache.org/licenses/LICENSE-2.0
6+
# Unless required by applicable law or agreed to in writing, software
7+
# distributed under the License is distributed on an "AS IS" BASIS,
8+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
9+
# See the License for the specific language governing permissions and
10+
# limitations under the License.
111
---
212
- name: "z/OS | Check ZOAU installation and version"
313
ansible.builtin.command:
@@ -49,23 +59,14 @@
4959
- iodf
5060
register: zos_facts
5161
rescue:
52-
- name: "z/OS | Fallback: Attempt to get IPL info via zinfo"
53-
ansible.builtin.command: |
54-
python3 -c
55-
"
56-
from zoautil_py import zsystem
57-
import sys
58-
print('Fallback zinfo query via Python: {0}'.format(sys.version))
59-
result=zsystem.zinfo(facts=['iplinfo'])
60-
if result:
61-
print(result)
62-
"
62+
- name: "z/OS | Fallback: Attempt to get IPL info via zinfo shell command"
63+
ansible.builtin.shell: "zinfo -a"
6364
register: zos_facts_fallback
6465
ignore_errors: true
6566

6667
- name: "z/OS | List installed pip packages"
6768
ansible.builtin.command:
68-
cmd: "pip3 list"
69+
cmd: "python3 -m pip list"
6970
register: managed_pip_list
7071
changed_when: false
7172
ignore_errors: true

0 commit comments

Comments
 (0)