From a372bd35059a4b1af966339b45258767e4a2d1bc Mon Sep 17 00:00:00 2001 From: cnfrancis <37379852+cnfrancis@users.noreply.github.com> Date: Tue, 14 Jan 2025 17:41:02 -0500 Subject: [PATCH] bug: missing until for retry in gce plugin (#288) fix: missing until for retry in gce plugin --- .../gce/playbooks/tasks/create_linux_instance.yml | 4 +++- .../gce/playbooks/tasks/create_windows_instance.yml | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/molecule_plugins/gce/playbooks/tasks/create_linux_instance.yml b/src/molecule_plugins/gce/playbooks/tasks/create_linux_instance.yml index bd705a1..a5efeb3 100644 --- a/src/molecule_plugins/gce/playbooks/tasks/create_linux_instance.yml +++ b/src/molecule_plugins/gce/playbooks/tasks/create_linux_instance.yml @@ -61,6 +61,8 @@ host: "{{ item.networkInterfaces.0.accessConfigs.0.natIP if molecule_yml.driver.external_access else item.networkInterfaces.0.networkIP }}" search_regex: SSH delay: 10 + loop: "{{ server.results }}" + register: waitfor + until: waitfor.failed == false retries: 6 delay: 10 - loop: "{{ server.results }}" diff --git a/src/molecule_plugins/gce/playbooks/tasks/create_windows_instance.yml b/src/molecule_plugins/gce/playbooks/tasks/create_windows_instance.yml index e828409..86e2a20 100644 --- a/src/molecule_plugins/gce/playbooks/tasks/create_windows_instance.yml +++ b/src/molecule_plugins/gce/playbooks/tasks/create_windows_instance.yml @@ -51,6 +51,10 @@ host: "{{ item.networkInterfaces.0.accessConfigs.0.natIP if molecule_yml.driver.external_access else item.networkInterfaces.0.networkIP }}" delay: 10 loop: "{{ server.results }}" + register: waitfor + until: waitfor.failed == false + retries: 6 + delay: 10 - name: Prepare Windows User ansible.builtin.script: >