Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Fix #23 - allow parallel execution #24

Closed
wants to merge 2 commits into from

Conversation

lod
Copy link
Contributor

@lod lod commented Aug 31, 2020

This patch prepends a string based on the role and scenario being tested to the front of the AWS element names.

This allows multiple roles to be tested at the same time. It also allows each scenario for a role to be run in parallel.

These features fix ansible-community/molecule-plugins#49

The optional environment variable override is designed to allow parallel functional testing by #21

Adding the scenario element does reverse the changes made by ansible/molecule#895
However I believe that the AWS requirements are unique due to the single namespace.

@lod lod force-pushed the fix/paralleltests branch from 11e7efb to 4b18645 Compare August 31, 2020 01:39
@lod
Copy link
Contributor Author

lod commented Aug 31, 2020

Force push dropped a cherrypick of 5118072 from #21

I didn't particularly like it, and it dragged in more elements than desired, like the region changes in #19

lod added 2 commits August 31, 2020 13:02
Elements like the ec2 key are unique by name in a region
Having a static name like 'molecule' prevents multiple tests
This is designed to allow parallel testing of the same role/scenario
For example, during the molecule-ec2 functional testing
@lod lod force-pushed the fix/paralleltests branch from 4b18645 to c024f4f Compare August 31, 2020 03:03
@lod
Copy link
Contributor Author

lod commented Aug 31, 2020

Push to fix spelling mistake in comments

As far as I can tell the linters are failing on two errors:

  • molecule_ec2/driver.py:257 """ doesn't start a new block on a new line
  • molecule_ec2/test/functional/test_ec2.py:46 small dictionary should be a single line

Neither of these two files were changed by this PR

@ssbarnea
Copy link
Member

@lod please rebase and sorry for missing it. Ping me on irc next time.

@ssbarnea
Copy link
Member

Apparently abandoned

@ssbarnea ssbarnea closed this Nov 27, 2020
@NicoGGG
Copy link
Contributor

NicoGGG commented Nov 28, 2020

Hello,

I would really need that change so I can try to finish this if OP can't right now.

Do I open a new PR or is it possible to take it from here ?

@ssbarnea
Copy link
Member

Create another one, is easier

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallel execution fails
3 participants