Document correction 2025 dec (#152)

Author: SreenidhiS1

plugins/modules/powervm_lpar_instance.py

@@ -307,7 +307,7 @@
             - Option to display advanced information of the logical partition.
             - Applicable only for C(facts) state.
             - Default is false.
-            - Currently it is showing only NPIV storage details.
+            - Currently it is showing only NPIV storage, SCSI adapters and Virtual Network adapter details.
         type: bool
     install_settings:
         description:
@@ -464,7 +464,7 @@
             - C(poweron) poweron a partition of the specified I(vm_name) with specified I(prof_name), I(keylock), I(iIPLsource) on specified I(system_name).
             - C(restart) restart a partition of the specified I(vm_name) on specified I(system_name).
             - C(install_os) install Aix/Linux OS through NIM Server on specified I(vm_name).
-            - C(modify_vm) rename a logical partition.
+            - C(modify_vm) rename a logical partition with I(new_vm_name).
         type: str
         choices: ['poweron', 'shutdown', 'restart', 'install_os', 'modify_vm']
 '''

tests/unit/modules/test_hmc_powervm.py

@@ -13,6 +13,7 @@
 virt_network_config = {'network_name': 'test'}
 install_Settings = {'vm_ip': '00.00.00.00', 'nim_ip': '00.00.00.00'}
 vnic_config = {'vnic_adapter_id': 0, 'backing_devices': 'bd'}
+update_config = {'new_vm_name': 'test'}
 test_data = [
     # ALL Create partition testdata
     # system name is missing
@@ -57,7 +58,7 @@
     # unsupported parameter os_type,proc,mem
     ({'hmc_host': "0.0.0.0", 'hmc_auth': hmc_auth, 'state': 'absent',
       'system_name': "systemname", 'vm_name': 'vmname', 'proc': '4', 'mem':
-      '1024', 'os_type': 'aix_linux', 'new_name': None, 'proc_unit': '4', 'prof_name': 'default', 'keylock': 'manual', 'iIPLsource': 'a',
+      '1024', 'os_type': 'aix_linux', 'proc_unit': '4', 'prof_name': 'default', 'keylock': 'manual', 'iIPLsource': 'a',
       'volume_config': volume_config, 'virt_network_config': virt_network_config, 'all_resources': True, 'max_virtual_slots': 25, 'advanced_info': True,
       'min_proc': '1', 'max_proc': '2', 'min_proc_unit': '0.1', 'max_proc_unit': '1', 'proc_mode': 'uncapped', 'weight': '124',
       'proc_compatibility_mode': 'POWER8', 'shared_proc_pool': '1', 'min_mem': '2048', 'max_mem': '1024', 'vm_id': 4, 'install_settings': install_Settings,
@@ -99,7 +100,7 @@
     ({'hmc_host': None, 'hmc_auth': hmc_auth, 'state': None, 'action': 'poweron',
       'system_name': "systemname", 'vm_name': "vm_name"}, "ParameterError: mandatory parameter 'hmc_host' is missing"),
     # hmc_auth is missing
-    ({'hmc_host': "0.0.0.0", 'hmc_auth': None, 'state': None, 'action': 'poweron',
+    ({'hmc_host': "0.0.0.0", 'hmc_auth': None, 'state': None, 'action': 'poweron', 'update_config': None,
       'system_name': "systemname", 'vm_name': "vmname"}, "ParameterError: mandatory parameter 'hmc_auth' is missing"),
     # unsupported parameter os_type,proc,mem
     ({'hmc_host': "0.0.0.0", 'hmc_auth': hmc_auth, 'state': None, 'action': 'poweron',
@@ -112,6 +113,23 @@
      "ParameterError: unsupported parameters: proc, mem, os_type, proc_unit, volume_config, virt_network_config, retain_vios_cfg, delete_vdisks,"
      " all_resources, max_virtual_slots, advanced_info, min_proc, max_proc, min_proc_unit, max_proc_unit, proc_mode, weight, proc_compatibility_mode,"
      " shared_proc_pool, min_mem, max_mem, vm_id, install_settings, vnic_config, shutdown_option, restart_option")]
+test_data4 = [
+    # ALL modify partition testdata
+    # vmname is missing
+    ({'hmc_host': "0.0.0.0", 'hmc_auth': hmc_auth, 'state': None, 'action': 'modify_vm',
+      'system_name': "systemname", 'vm_name': None, 'update_config': update_config}, "ParameterError: mandatory parameter 'vm_name' is missing"),
+    # update config is missing
+    ({'hmc_host': "0.0.0.0", 'hmc_auth': hmc_auth, 'state': None, 'action': 'modify_vm',
+      'system_name': "systemname", 'vm_name': 'vm_name', 'update_config': None}, "ParameterError: mandatory parameter 'update_config' is missing"),
+    # system name is missing
+    ({'hmc_host': "0.0.0.0", 'hmc_auth': hmc_auth, 'state': None, 'action': 'modify_vm',
+      'system_name': None, 'vm_name': 'vm_name', 'update_config': update_config}, "ParameterError: mandatory parameter 'system_name' is missing"),
+    # hmc host is missing
+    ({'hmc_host': None, 'hmc_auth': hmc_auth, 'state': None, 'action': 'modify_vm',
+      'system_name': 'systemname', 'vm_name': 'vm_name', 'update_config': update_config}, "ParameterError: mandatory parameter 'hmc_host' is missing"),
+    # hmc_auth is missing
+    ({'hmc_host': '0.0.0.0', 'hmc_auth': None, 'state': None, 'action': 'modify_vm',
+      'system_name': 'systemname', 'vm_name': 'vm_name', 'update_config': update_config}, "ParameterError: mandatory parameter 'hmc_auth' is missing")]
 
 
 def common_mock_setup(mocker):
@@ -163,3 +181,14 @@ def test_call_inside_powervm_poweron_partition(mocker, powervm_test_input, expec
         assert expectedError == repr(e.value)
     else:
         hmc_powervm.poweron_partition(hmc_powervm, powervm_test_input)
+
+
+@pytest.mark.parametrize("powervm_test_input, expectedError", test_data3)
+def test_call_inside_powervm_poweron_partition(mocker, powervm_test_input, expectedError):
+    hmc_powervm = common_mock_setup(mocker)
+    if 'ParameterError' in expectedError:
+        with pytest.raises(ParameterError) as e:
+            hmc_powervm.rename_partition(hmc_powervm, powervm_test_input)
+        assert expectedError == repr(e.value)
+    else:
+        hmc_powervm.rename_partition(hmc_powervm, powervm_test_input)