Skip to content

Commit ba642e9

Browse files
AnilVijayanAnilVijayan
authored
Fix the linting issues (#77) (#144)
Fix the linting issue reported during Redhat upload --------- Co-authored-by: anilvijayan@in.ibm.com
1 parent ec6d32c commit ba642e9

28 files changed

+609
-330
lines changed

‎.github/workflows/doc-publish.yaml‎

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -21,27 +21,27 @@ jobs:
2121

2222
name: generate documenation source files
2323
steps:
24-
- name: checkout repository
25-
uses: actions/checkout@v4
26-
- name: setup python
27-
uses: actions/setup-python@v5.0.0
28-
with:
29-
python-version: ${{ matrix.python-version }}
30-
- name: install document generation requirements
31-
run: |
32-
python -m pip install --upgrade pip
33-
python -m pip install ansible
34-
python -m pip install ansible-doc-extractor
35-
python -m pip install sphinx
36-
python -m pip install sphinx_rtd_theme
37-
python -m pip install --upgrade myst-parser
38-
- name: run document generator script
39-
run: |
40-
bash devops/bin/gen_doc.sh
41-
- uses: actions/upload-artifact@v3
42-
with:
43-
name: hmc-doc-artifact
44-
path: ./docs/build
24+
- name: checkout repository
25+
uses: actions/checkout@v4
26+
- name: setup python
27+
uses: actions/setup-python@v5.0.0
28+
with:
29+
python-version: ${{ matrix.python-version }}
30+
- name: install document generation requirements
31+
run: |
32+
python -m pip install --upgrade pip
33+
python -m pip install ansible
34+
python -m pip install ansible-doc-extractor
35+
python -m pip install sphinx
36+
python -m pip install sphinx_rtd_theme
37+
python -m pip install --upgrade myst-parser
38+
- name: run document generator script
39+
run: |
40+
bash devops/bin/gen_doc.sh
41+
- uses: actions/upload-artifact@v3
42+
with:
43+
name: hmc-doc-artifact
44+
path: ./docs/build
4545

4646
deploy-doc:
4747
runs-on: ubuntu-22.04
@@ -54,19 +54,19 @@ jobs:
5454
pages: write
5555

5656
steps:
57-
- uses: actions/download-artifact@v3
58-
with:
59-
name: hmc-doc-artifact
60-
path: .
61-
- uses: actions/configure-pages@v4
62-
with:
63-
#User need to set this secret on github actions
64-
token: ${{ secrets.TOKEN_PAM }}
65-
enablement: true
66-
- uses: actions/upload-pages-artifact@v1
67-
with:
68-
path: .
69-
- id: deployment
70-
uses: actions/deploy-pages@v3
71-
with:
72-
token: ${{ secrets.TOKEN_PAM }}
57+
- uses: actions/download-artifact@v3
58+
with:
59+
name: hmc-doc-artifact
60+
path: .
61+
- uses: actions/configure-pages@v4
62+
with:
63+
# User need to set this secret on github actions
64+
token: ${{ secrets.TOKEN_PAM }}
65+
enablement: true
66+
- uses: actions/upload-pages-artifact@v1
67+
with:
68+
path: .
69+
- id: deployment
70+
uses: actions/deploy-pages@v3
71+
with:
72+
token: ${{ secrets.TOKEN_PAM }}

‎.github/workflows/linting.yaml‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
branches:
88
- '*'
99
pull_request:
10-
branches: [ dev-collection ]
10+
branches: [dev-collection]
1111

1212
# Allows you to run this workflow manually from the Actions tab
1313
workflow_dispatch:
@@ -21,28 +21,28 @@ jobs:
2121

2222
name: run module linting
2323
steps:
24-
- name: checkout repository
25-
uses: actions/checkout@v4
26-
27-
- name: setup python
28-
uses: actions/setup-python@v5
29-
with:
30-
python-version: ${{ matrix.python-version }}
31-
32-
- name: install linting test requirements
33-
run: |
34-
python -m pip install --upgrade pip
35-
make install-ansible
36-
make install-sanity-test-requirements
37-
make install-ansible-lint
38-
39-
- name: build and install new content as collection
40-
run: |
41-
make prep-collection
42-
43-
- name: run linter
44-
run: make module-lint
45-
working-directory: /home/runner/.ansible/collections/ansible_collections/ibm/power_hmc
46-
47-
- name: run install-ansible
48-
run: make ansible-lint
24+
- name: checkout repository
25+
uses: actions/checkout@v4
26+
27+
- name: setup python
28+
uses: actions/setup-python@v5
29+
with:
30+
python-version: ${{ matrix.python-version }}
31+
32+
- name: install linting test requirements
33+
run: |
34+
python -m pip install --upgrade pip
35+
make install-ansible
36+
make install-sanity-test-requirements
37+
make install-ansible-lint
38+
39+
- name: build and install new content as collection
40+
run: |
41+
make prep-collection
42+
43+
- name: run linter
44+
run: make module-lint
45+
working-directory: /home/runner/.ansible/collections/ansible_collections/ibm/power_hmc
46+
47+
- name: run install-ansible
48+
run: make ansible-lint

‎.github/workflows/unit-tests.yaml‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
branches:
88
- '*'
99
pull_request:
10-
branches: [ dev-collection ]
10+
branches: [dev-collection]
1111

1212
# Allows you to run this workflow manually from the Actions tab
1313
workflow_dispatch:
@@ -21,22 +21,22 @@ jobs:
2121

2222
name: running unit tests with python ${{ matrix.python-version }}
2323
steps:
24-
- name: checkout repository
25-
uses: actions/checkout@v4
26-
27-
- name: setup python
28-
uses: actions/setup-python@v5
29-
with:
30-
python-version: ${{ matrix.python-version }}
31-
32-
- name: install ansible ${{ matrix.ansible-version }}
33-
run: |
34-
make install-ansible
35-
36-
- name: install python modules needed for unit testing
37-
run: |
38-
make install-unit-test-requirements
39-
40-
- name: run unit tests
41-
run: |
42-
make unit-test PYTHON_VERSION=${{ matrix.python-version }}
24+
- name: checkout repository
25+
uses: actions/checkout@v4
26+
27+
- name: setup python
28+
uses: actions/setup-python@v5
29+
with:
30+
python-version: ${{ matrix.python-version }}
31+
32+
- name: install ansible ${{ matrix.ansible-version }}
33+
run: |
34+
make install-ansible
35+
36+
- name: install python modules needed for unit testing
37+
run: |
38+
make install-unit-test-requirements
39+
40+
- name: run unit tests
41+
run: |
42+
make unit-test PYTHON_VERSION=${{ matrix.python-version }}

0 commit comments

Comments
 (0)