Skip to content

Commit 1fc5f5e

Browse files
committed
update aap_31381
1 parent 3e68a7d commit 1fc5f5e

File tree

6 files changed

+100
-60
lines changed

6 files changed

+100
-60
lines changed

ansible_ai_connect_admin_portal/package-lock.json

Lines changed: 61 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ansible_ai_connect_admin_portal/package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"i18next-http-backend": "^2.2.1",
2020
"react": "^18.2.0",
2121
"react-dom": "^18.2.0",
22-
"react-i18next": "^13.1.2",
23-
"react-router-dom": "^6.15.0"
22+
"react-i18next": "^13.1.2"
2423
},
2524
"devDependencies": {
2625
"@testing-library/jest-dom": "^6.1.4",
@@ -82,7 +81,9 @@
8281
"webpack-dev-server": "^4.6.0",
8382
"webpack-manifest-plugin": "^4.0.2",
8483
"webpack-mock-server": "^1.0.18",
85-
"workbox-webpack-plugin": "^6.4.1"
84+
"workbox-webpack-plugin": "^6.4.1",
85+
"react-router-dom": "^6.28.0",
86+
"identity-obj-proxy": "^3.0.0"
8687
},
8788
"scripts": {
8889
"start": "node scripts/start.js",
@@ -145,9 +146,8 @@
145146
"moduleNameMapper": {
146147
"^react-native$": "react-native-web",
147148
"^.+\\.module\\.(css|sass|scss)$": "identity-obj-proxy",
148-
"react-i18next": "<rootDir>/__mocks__/react-i18next.ts"
149-
},
150-
"module.exports": {
149+
"react-i18next": "<rootDir>/__mocks__/react-i18next.ts",
150+
"\\.(css|less|scss|sass)$": "identity-obj-proxy",
151151
"monaco-editor": "<rootDir>/__mocks__/monaco-editor.ts",
152152
"monaco-yaml": "<rootDir>/__mocks__/monaco-yaml.ts"
153153
},

ansible_ai_connect_admin_portal/src/PageMastheadDropdown.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export function PageMastheadDropdown(props: PageMastheadDropdownProps) {
3232
id={id}
3333
onSelect={onSelect}
3434
toggle={(toggleRef: React.Ref<MenuToggleElement>) => (
35-
<MenuToggle ref={toggleRef} onClick={onToggle} isExpanded={isOpen}>
35+
<MenuToggle ref={toggleRef} onClick={onToggle} isExpanded={isOpen} data-testid="page-masthead-dropdown__button">
3636
<Flex
3737
alignItems={{ default: "alignItemsCenter" }}
3838
flexWrap={{ default: "nowrap" }}
@@ -46,7 +46,7 @@ export function PageMastheadDropdown(props: PageMastheadDropdownProps) {
4646
isOpen={open}
4747
isPlain
4848
data-cy={id}
49-
data-testid="page-masthead-dropdown"
49+
data-testid="page-masthead-dropdown__button"
5050
>
5151
<DropdownList>
5252
<DropdownItem>{_children}</DropdownItem>

ansible_ai_connect_admin_portal/src/__tests__/App.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ describe("App", () => {
1616
adminDashboardUrl={"http://admin_dashboard-url/"}
1717
/>,
1818
);
19-
const accountMenu = await screen.findByTestId("page-masthead-dropdown");
19+
const accountMenu = await screen.findByTestId("page-masthead-dropdown__button");
2020
expect(accountMenu).toBeInTheDocument();
2121
expect(accountMenu).toHaveTextContent("Batman");
2222
});
Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
import { render, screen } from "@testing-library/react";
1+
import { render, screen, waitFor } from "@testing-library/react";
22
import "@testing-library/jest-dom";
33
import { AppHeader } from "../AppHeader";
44
import userEvent from "@testing-library/user-event";
5+
import { BrowserRouter } from 'react-router-dom';
6+
import { act } from 'react';
57

68
describe("AppHeader", () => {
79
// Store the original 'location' object so that it can be restored for other tests.
@@ -20,26 +22,40 @@ describe("AppHeader", () => {
2022
});
2123

2224
it("Rendering", async () => {
23-
render(<AppHeader userName={"Batman"} />);
24-
const accountMenu = await screen.findByTestId("page-masthead-dropdown");
25+
render(
26+
<BrowserRouter>
27+
<AppHeader userName={"Batman"} />
28+
</BrowserRouter>
29+
);
30+
const accountMenu = await screen.findByTestId("page-masthead-dropdown__button");
2531
expect(accountMenu).toBeInTheDocument();
2632
expect(accountMenu).toHaveTextContent("Batman");
2733

2834
// Check "Logout" option is not present
2935
expect(screen.queryByText("Logout")).toBeNull();
30-
31-
// Emulate click on menu button
32-
const accountMenuToggle = await screen.findByTestId(
33-
"page-masthead-dropdown__button",
34-
);
35-
await userEvent.click(accountMenuToggle);
36-
36+
const accountMenuToggle = await act(()=> {
37+
screen.findByTestId(
38+
"page-masthead-dropdown__button",
39+
);
40+
});
41+
// const accountMenuToggle = await screen.findByTestId(
42+
// "page-masthead-dropdown__button",
43+
// );
44+
await act(() => {
45+
userEvent.click(accountMenuToggle);
46+
});
47+
// await userEvent.click(accountMenuToggle);
3748
// "Logout" menu option should now be present
3849
expect(await screen.findByText("Logout")).toBeInTheDocument();
3950

4051
// Emulate clicking on the logout button
41-
const logoutMenuItem = await screen.findByTestId("app-header__logout");
52+
const logoutMenuItem = await act(() => {
53+
screen.findByTestId("app-header__logout");
54+
});
55+
// await act(() => {
56+
// userEvent.click(logoutMenuItem);
57+
// });
4258
await userEvent.click(logoutMenuItem);
43-
expect(window.location.assign).toBeCalledWith("/logout");
59+
expect(window.location.assign).toHaveBeenCalledWith("/logout");
4460
});
4561
});

ansible_ai_connect_admin_portal/src/denied/__tests__/AppDenied.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ describe("App", () => {
66
it("Rendering::With Username", async () => {
77
window.history.pushState({}, "Test page", "/console");
88
render(<AppDenied userName={"Batman"} hasSubscription={true} />);
9-
const accountMenu = await screen.findByTestId("page-masthead-dropdown");
9+
const accountMenu = await screen.findByTestId("page-masthead-dropdown__button");
1010
expect(accountMenu).toBeInTheDocument();
1111
expect(accountMenu).toHaveTextContent("Batman");
1212
});
1313

1414
it("Rendering::Without Username", async () => {
1515
window.history.pushState({}, "Test page", "/console");
1616
render(<AppDenied hasSubscription={false} />);
17-
const accountMenu = await screen.findByTestId("page-masthead-dropdown");
17+
const accountMenu = await screen.findByTestId("page-masthead-dropdown__button");
1818
expect(accountMenu).toBeInTheDocument();
1919
expect(accountMenu).toHaveTextContent("UnknownUser");
2020
});

0 commit comments

Comments
 (0)