Skip to content

Commit c4afbc2

Browse files
authored
Chat conversation_id can be a non-UUID string in newer Llama Stack versions (#1958)
1 parent b2bcfa2 commit c4afbc2

File tree

4 files changed

+11
-19
lines changed

4 files changed

+11
-19
lines changed

ansible_ai_connect/ai/api/serializers.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -319,11 +319,10 @@ class RoleGenerationAction(PlaybookGenerationAction):
319319

320320

321321
class ChatRequestSerializer(serializers.Serializer):
322-
conversation_id = serializers.UUIDField(
323-
format="hex_verbose",
322+
conversation_id = serializers.CharField(
324323
required=False,
325324
label="conversation ID",
326-
help_text=("A UUID that identifies the particular conversation is being requested for."),
325+
help_text=("An ID that identifies the particular conversation is being requested for."),
327326
)
328327
query = serializers.CharField(
329328
required=True,
@@ -366,11 +365,10 @@ class ReferencedDocumentsSerializer(serializers.Serializer):
366365

367366

368367
class ChatResponseSerializer(serializers.Serializer):
369-
conversation_id = serializers.UUIDField(
370-
format="hex_verbose",
368+
conversation_id = serializers.CharField(
371369
required=True,
372370
label="conversation ID",
373-
help_text=("A UUID that identifies the particular conversation is being requested for."),
371+
help_text=("An ID that identifies the particular conversation is being requested for."),
374372
)
375373
referenced_documents = serializers.ListField(
376374
child=ReferencedDocumentsSerializer(), required=False

ansible_ai_connect/ai/api/tests/test_chat_view.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class TestChatView(APIVersionTestCaseBase, WisdomServiceAPITestCaseBase):
5858

5959
VALID_PAYLOAD_WITH_CONVERSATION_ID = {
6060
"query": "Hello",
61-
"conversation_id": "123e4567-e89b-12d3-a456-426614174000",
61+
"conversation_id": "ABC-123e4567-e89b-12d3-a456-426614174000", # Non-UUIDs are fine here.
6262
}
6363

6464
INVALID_PAYLOAD = {

tools/openapi-schema/ansible-ai-connect-service.json

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1299,8 +1299,7 @@
12991299
"properties": {
13001300
"conversation_id": {
13011301
"type": "string",
1302-
"format": "uuid",
1303-
"description": "A UUID that identifies the particular conversation is being requested for."
1302+
"description": "An ID that identifies the particular conversation is being requested for."
13041303
},
13051304
"query": {
13061305
"type": "string",
@@ -1336,8 +1335,7 @@
13361335
"properties": {
13371336
"conversation_id": {
13381337
"type": "string",
1339-
"format": "uuid",
1340-
"description": "A UUID that identifies the particular conversation is being requested for."
1338+
"description": "An ID that identifies the particular conversation is being requested for."
13411339
},
13421340
"referenced_documents": {
13431341
"type": "array",
@@ -2188,8 +2186,7 @@
21882186
"properties": {
21892187
"conversation_id": {
21902188
"type": "string",
2191-
"format": "uuid",
2192-
"description": "A UUID that identifies the particular conversation is being requested for."
2189+
"description": "An ID that identifies the particular conversation is being requested for."
21932190
},
21942191
"query": {
21952192
"type": "string",

tools/openapi-schema/ansible-ai-connect-service.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -822,8 +822,7 @@ components:
822822
properties:
823823
conversation_id:
824824
type: string
825-
format: uuid
826-
description: A UUID that identifies the particular conversation is being
825+
description: An ID that identifies the particular conversation is being
827826
requested for.
828827
query:
829828
type: string
@@ -852,8 +851,7 @@ components:
852851
properties:
853852
conversation_id:
854853
type: string
855-
format: uuid
856-
description: A UUID that identifies the particular conversation is being
854+
description: An ID that identifies the particular conversation is being
857855
requested for.
858856
referenced_documents:
859857
type: array
@@ -1512,8 +1510,7 @@ components:
15121510
properties:
15131511
conversation_id:
15141512
type: string
1515-
format: uuid
1516-
description: A UUID that identifies the particular conversation is being
1513+
description: An ID that identifies the particular conversation is being
15171514
requested for.
15181515
query:
15191516
type: string

0 commit comments

Comments
 (0)