Skip to content

Commit 55a0301

Browse files
lucasc017claude
andcommitted
[AAP-71476] Pass secrets via env block instead of command line in CI workflow
Move PDE_ORG_RESULTS_UPLOAD_PASSWORD from curl command-line argument to step env block to avoid exposing the secret in process listings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 77920ca commit 55a0301

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,12 @@ jobs:
9595
if: matrix.tests.junit-xml-upload && github.event_name == 'push' && github.repository == 'ansible/django-ansible-base' && github.ref_name == 'devel'
9696
continue-on-error: true
9797
run: >-
98-
curl -v --user "${{ vars.PDE_ORG_RESULTS_AGGREGATOR_UPLOAD_USER }}:${{ secrets.PDE_ORG_RESULTS_UPLOAD_PASSWORD }}"
98+
curl -v --user "$PDE_UPLOAD_USER:$PDE_UPLOAD_PASSWORD"
9999
--form "xunit_xml=@django-ansible-base-test-results.xml"
100100
--form "component_name=django-ansible-base"
101101
--form "git_commit_sha=${{ github.sha }}"
102102
--form "git_repository_url=https://github.com/${{ github.repository }}"
103103
"${{ vars.PDE_ORG_RESULTS_AGGREGATOR_UPLOAD_URL }}/api/results/upload/"
104+
env:
105+
PDE_UPLOAD_USER: ${{ vars.PDE_ORG_RESULTS_AGGREGATOR_UPLOAD_USER }}
106+
PDE_UPLOAD_PASSWORD: ${{ secrets.PDE_ORG_RESULTS_UPLOAD_PASSWORD }}

0 commit comments

Comments
 (0)