Commit 9e91804
[AAP-71476] Fix SonarCloud reliability and security issues (#989)
## Summary
- Remove duplicate `id` attributes from inline SVGs in JWT consumer
redirect page (63 reliability issues)
- Replace `[` / `test` with `[[` in shell scripts for safer conditionals
(6 reliability issues)
- Replace `permissions: read-all` with specific scopes in SonarCloud
workflow (1 security vulnerability)
- Pass secrets via `env:` block instead of command line in CI workflow
(1 security hotspot)
Additionally, the following were reviewed and resolved in the SonarCloud
UI:
- 5 security vulnerabilities marked as accepted risk (loosely-pinned dev
deps, Poetry source builds)
- 1 security vulnerability marked as won't fix (dev-only hard-coded
password in test_app)
- 3 security hotspots marked as safe (dev Postgres password, internal
dvcs-action@devel, Google Fonts SRI incompatibility)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Safer CI credential handling and quieter test-report uploads.
* Reduced workflow permissions to follow least-privilege principles.
* **Style**
* Simplified embedded SVG markup in redirect pages while preserving
visuals.
* Modernized shell script conditionals for consistency and
maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent d4ea85e commit 9e91804
5 files changed
Lines changed: 88 additions & 82 deletions
File tree
- .github/workflows
- ansible_base/jwt_consumer
- requirements
- test_app/scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
34 | 37 | | |
35 | 38 | | |
36 | 39 | | |
| |||
0 commit comments