AAP-60826 Add Annon condition to visible_users (#919)

Add condition for when we don't have a database or nothing.

Fails-safe, returning valid queryset with no objects.

Addresses the issue of missing components and data in
openapi schema.

Author: AlanCoding

ansible_base/rbac/policies.py

@@ -16,6 +16,10 @@
 def visible_users(request_user, queryset=None, always_show_superusers=True, always_show_self=True) -> QuerySet:
     """Gives a queryset of users that another user should be able to view"""
     user_cls = permission_registry.user_model
+
+    if not getattr(request_user, "is_authenticated", False):
+        return user_cls.objects.none()
+
     org_cls = apps.get_model(settings.ANSIBLE_BASE_ORGANIZATION_MODEL)
 
     if can_view_all_users(request_user):

test_app/tests/rbac/test_policies.py

@@ -1,6 +1,7 @@
 import pytest
+from django.contrib.auth.models import AnonymousUser
 
-from ansible_base.rbac.policies import can_change_user
+from ansible_base.rbac.policies import can_change_user, visible_users
 from test_app.models import User
 
 
@@ -32,3 +33,12 @@ def test_superuser_can_change_new_user(admin_user):
 def test_user_can_manage_themselves():
     alice = User.objects.create(username='alice')
     assert can_change_user(alice, alice)
+
+
+@pytest.mark.django_db
+def test_visible_users_anonymous_user():
+    User.objects.create(username='alice')
+    User.objects.create(username='bob', is_superuser=True)
+
+    qs = visible_users(AnonymousUser())
+    assert not qs.exists()