Skip to content

Commit ce2a95d

Browse files
Apply suggestion from @john-westcott-iv
1 parent 21b7066 commit ce2a95d

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

ansible_base/oauth2_provider/models/access_token.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,9 @@ def is_valid(self, scopes=None):
8282
self.last_used = now()
8383

8484
def _update_last_used():
85+
# QuerySet.update() is used instead of save() to avoid a race condition
86+
# where concurrent requests updating last_used can cause DatabaseError.
87+
# This is safe because last_used is a trivial field with no save() side effects.
8588
OAuth2AccessToken.objects.filter(pk=self.pk).update(last_used=self.last_used)
8689

8790
connection.on_commit(_update_last_used)

0 commit comments

Comments
 (0)