Consolidate command class loggers into base.Base property (#4486)

Depends on PR #4487 

Problem: Command classes had duplicate logger setup code across 7+
files.
Solution: Single @Property _log in base.Base with automatic step
derivation.

Key Changes:
- Added @Property _log to base.Base with automatic step naming
- Removed individual logger setups from 7 command classes  
- Eliminated 50+ lines of duplicate code
- Updated tests for scenario logger pattern

Impact:
- Future command classes get logger automatically
- Consistent scenario->step format across all commands
- Perfect architectural separation of concerns

Testing: All command tests pass with proper context validation.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: cidrblock

src/molecule/command/base.py

@@ -81,6 +81,16 @@ def __init_subclass__(cls) -> None:
         for wrapper in logger.get_section_loggers():
             cls.execute = wrapper(cls.execute)  # type: ignore[method-assign,assignment]
 
+    @property
+    def _log(self) -> logger.ScenarioLoggerAdapter:
+        """Get a scenario logger with command-specific step context.
+
+        Returns:
+            A scenario logger adapter with current scenario and step context.
+        """
+        step_name = self.__class__.__name__.lower()
+        return logger.get_scenario_logger(__name__, self._config.scenario.name, step_name)
+
     @abc.abstractmethod
     def execute(
         self,

src/molecule/command/cleanup.py

@@ -23,7 +23,6 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import config, logger
 from molecule.click_cfg import click_command_ex, common_options
 from molecule.command import base
 
@@ -37,15 +36,6 @@
 class Cleanup(base.Base):
     """Cleanup Command Class."""
 
-    def __init__(self, c: config.Config) -> None:
-        """Initialize Cleanup command.
-
-        Args:
-            c: An instance of a Molecule config.
-        """
-        super().__init__(c)
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
-
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to cleanup the instances.
 

src/molecule/command/create.py

@@ -23,7 +23,6 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import config, logger
 from molecule.click_cfg import click_command_ex, common_options
 from molecule.command import base
 
@@ -37,15 +36,6 @@
 class Create(base.Base):
     """Create Command Class."""
 
-    def __init__(self, c: config.Config) -> None:
-        """Initialize Create command.
-
-        Args:
-            c: An instance of a Molecule config.
-        """
-        super().__init__(c)
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
-
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to perform a `molecule create`.
 

src/molecule/command/destroy.py

@@ -23,7 +23,6 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import config, logger
 from molecule.click_cfg import click_command_ex, common_options
 from molecule.command import base
 
@@ -37,15 +36,6 @@
 class Destroy(base.Base):
     """Destroy Command Class."""
 
-    def __init__(self, c: config.Config) -> None:
-        """Initialize Destroy command.
-
-        Args:
-            c: An instance of a Molecule config.
-        """
-        super().__init__(c)
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
-
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to perform a `molecule destroy`.
 

src/molecule/command/idempotence.py

@@ -25,7 +25,6 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import config, logger
 from molecule.click_cfg import click_command_ex, common_options
 from molecule.command import base
 from molecule.exceptions import ScenarioFailureError
@@ -45,15 +44,6 @@ class Idempotence(base.Base):
     the scenario will be considered idempotent.
     """
 
-    def __init__(self, c: config.Config) -> None:
-        """Initialize Idempotence command.
-
-        Args:
-            c: An instance of a Molecule config.
-        """
-        super().__init__(c)
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
-
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to perform a `molecule idempotence`.
 

src/molecule/command/init/scenario.py

@@ -98,7 +98,7 @@ def __init__(self, config: Config, command_args: CommandArgs) -> None:
         self._command_args = command_args
         # For init scenario, use the scenario name from command args
         scenario_name = command_args.get("scenario_name", "unknown")
-        self._log = logger.get_scenario_logger(__name__, scenario_name)
+        self._log = logger.get_scenario_logger(__name__, scenario_name, "init")
 
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to perform a `molecule init scenario`.

src/molecule/command/login.py

@@ -27,7 +27,7 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import logger, scenarios
+from molecule import scenarios
 from molecule.click_cfg import click_command_ex, options
 from molecule.command import base
 from molecule.exceptions import MoleculeError
@@ -51,7 +51,6 @@ def __init__(self, c: config.Config) -> None:
         """
         super().__init__(c)
         self._pt = None
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
 
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to perform a `molecule login`.

src/molecule/command/prepare.py

@@ -23,7 +23,6 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import config, logger
 from molecule.click_cfg import click_command_ex, common_options
 from molecule.command import base
 
@@ -87,15 +86,6 @@ class Prepare(base.Base):
         molecule.yml.
     """
 
-    def __init__(self, c: config.Config) -> None:
-        """Initialize Prepare command.
-
-        Args:
-            c: An instance of a Molecule config.
-        """
-        super().__init__(c)
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
-
     def execute(self, action_args: list[str] | None = None) -> None:  # noqa: ARG002
         """Execute the actions necessary to prepare the instances.
 

src/molecule/command/side_effect.py

@@ -23,7 +23,6 @@
 
 from typing import TYPE_CHECKING
 
-from molecule import config, logger
 from molecule.click_cfg import click_command_ex, common_options
 from molecule.command import base
 
@@ -40,15 +39,6 @@ class SideEffect(base.Base):
     See the provisioners documentation for further details.
     """
 
-    def __init__(self, c: config.Config) -> None:
-        """Initialize SideEffect command.
-
-        Args:
-            c: An instance of a Molecule config.
-        """
-        super().__init__(c)
-        self._log = logger.get_scenario_logger(__name__, self._config.scenario.name)
-
     def execute(self, action_args: list[str] | None = None) -> None:
         """Execute the actions necessary to perform a `molecule side-effect`.
 

src/molecule/logger.py

@@ -247,22 +247,20 @@ def process(
 def get_scenario_logger(
     name: str,
     scenario_name: str,
-    step_name: str | None = None,
+    step_name: str,
 ) -> ScenarioLoggerAdapter:
     """Return a scenario-aware logger that includes scenario name in all messages.
 
     Args:
         name: Name of the child logger.
         scenario_name: Name of the scenario for context.
-        step_name: Optional step name (e.g., 'converge', 'create', 'destroy').
+        step_name: Step name (e.g., 'converge', 'create', 'destroy').
 
     Returns:
         A ScenarioLoggerAdapter that includes scenario context in all messages.
     """
     logger = get_logger(name)
-    extra = {"scenario_name": scenario_name}
-    if step_name:
-        extra["step_name"] = step_name
+    extra = {"scenario_name": scenario_name, "step_name": step_name}
     return ScenarioLoggerAdapter(logger, extra)