Skip to content

receptor_replace_tls should be true by default #71

Open
@kurokobo

Description

@kurokobo

receptor_replace_tls is introduced by #39 and its default value is false, but I believe this should be true by default. Or in the first place, I think there is no need to allow this parameter to be changed. Keeping module default (true) and removing receptor_replace_tls should be better.

I assume the reason for the default value (false) is to avolid handler to be triggered every time by the task with ansible.builtin.copy with force: true, which results always changed.

However, force: true for the ansible.builtin.copy module does not break idempotency, as documented below.

If true, the remote file will be replaced when contents are different than the source.
If false, the file will only be transferred if the destination does not exist.
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/copy_module.html

Any certificates should be copied if the file contents are different, even if the file already exists. Also, for worksign cert, force for copy module is left at the default true: https://github.com/ansible/receptor-collection/blob/be929596f0598e0ac3956f3430bbae8603d3448f/roles/setup/tasks/worksign_local.yml

@fosterseth
Could you please tell me if there is any particular reason why you set the default to false in #39?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions