chore: replace mocha with vitest for 'task unit' (#2347)

ssbarnea · web-flow · commit 2284692ad897 · 2025-12-04T12:00:20.000Z
diff --git a/.depcheckrc.yml b/.depcheckrc.yml
@@ -1,9 +1,10 @@
 # https://github.com/yarnpkg/yarn/issues/3368
 ignores:
-  - "@ansible/ansible-mcp-server"
   - "@ansible/ansible-language-server"
-  - "@types/vscode-webview" # provides VSCodeAPI
+  - "@ansible/ansible-mcp-server"
   - "@types/vscode"  # determined by (package.json).engines.vscode
+  - "@types/vscode-webview" # provides VSCodeAPI
+  - "@vitest/coverage-v8"
   - "@vscode/test-electron" # used by @vscode/test-cli
   - "@vscode/vsce"
   - cypress-multi-reporters
diff --git a/.gitignore b/.gitignore
@@ -18,7 +18,6 @@ CHANGELOG.html
 !.yarn/sdks
 !.yarn/versions
 .DS_Store
-coverage
 .nyc_output
 .idea
 *.pyc
diff --git a/.mocharc.js b/.mocharc.js
diff --git a/Taskfile.yml b/Taskfile.yml
@@ -215,7 +215,7 @@ tasks:
     generates:
       - out/coverage/unit/lcov.info
     cmds:
-      - c8 --config test/unit/.c8rc.json mocha {{ .MOCHA_OPTS }}
+      - vitest run
     interactive: true
   package:
     desc: Package extension
@@ -272,4 +272,4 @@ tasks:
     deps:
       - package
     cmds:
-      - mocha --dry-run
+      - vitest list
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -10,7 +10,6 @@ import globals from "globals";
 import path from "path";
 import { fileURLToPath } from "url";
 import html from "@html-eslint/eslint-plugin";
-import mochaPlugin from "eslint-plugin-mocha";
 import { defineConfig } from "eslint/config";
 
 const __filename = fileURLToPath(import.meta.url); // get the resolved path to the file
@@ -68,10 +67,8 @@ export default defineConfig(
       // loaded implicitly, will trigger 'Cannot redefine plugin' if enabled:
       // "@typescript-eslint": ts,
       tsdoc: tsdocPlugin,
-      mocha: mochaPlugin,
     },
     rules: {
-      "mocha/max-top-level-suites": ["warn", { limit: 1 }],
       eqeqeq: ["error", "smart"],
       // Needed for tseslint.configs.strictTypeChecked
       "@typescript-eslint/no-namespace": "error",
diff --git a/package.json b/package.json
@@ -1032,6 +1032,8 @@
     "@types/vscode-webview": "^1.57.5",
     "@types/yargs": "^17.0.35",
     "@typescript-eslint/parser": "^8.48.0",
+    "@vitest/coverage-v8": "^4.0.14",
+    "@vitest/ui": "^4.0.4",
     "@vscode/test-cli": "^0.0.12",
     "@vscode/test-electron": "^2.5.2",
     "@vscode/vsce": "^3.7.1",
@@ -1043,7 +1045,6 @@
     "eslint-formatter-gha": "^1.6.0",
     "eslint-formatter-unix": "^9.0.1",
     "eslint-plugin-chai-friendly": "^1.1.0",
-    "eslint-plugin-mocha": "^11.2.0",
     "eslint-plugin-prettier": "^5.5.4",
     "eslint-plugin-tsdoc": "^0.5.0",
     "express": "^5.1.0",
@@ -1052,8 +1053,6 @@
     "globals": "^16.5.0",
     "jsdom": "^27.2.0",
     "lodash": "^4.17.21",
-    "mocha": "^11.7.5",
-    "mocha-junit-reporter": "^2.2.1",
     "mocha-multi-reporters": "^1.5.1",
     "morgan": "^1.10.1",
     "npm-check-updates": "^19.1.2",
@@ -1068,6 +1067,7 @@
     "tsx": "^4.20.6",
     "typescript": "^5.9.3",
     "typescript-eslint": "^8.48.0",
+    "vitest": "^4.0.14",
     "vscode-extension-tester": "^8.19.0",
     "warnings-to-errors-webpack-plugin": "^2.3.0",
     "webpack": "^5.103.0",
diff --git a/packages/ansible-language-server/.c8rc.json b/packages/ansible-language-server/.c8rc.json
@@ -1,5 +1,5 @@
 {
-  "branches": 80.31,
+  "branches": 81.24,
   "check-coverage": true,
   "extends": "../../.c8rc.json",
   "lines": 0,
diff --git a/renovate.json b/renovate.json
@@ -13,7 +13,6 @@
   ],
   "github-actions": {
     "branchTopic": "build",
-    "commitMessageTopic": "github actions",
     "enabled": true,
     "groupName": "github actions",
     "groupSlug": "actions",
@@ -58,15 +57,13 @@
     },
     {
       "branchTopic": "npm-dev",
-      "commitMessageTopic": "npm dev",
       "groupSlug": "npm-dev",
       "matchDepTypes": ["devDependencies"],
       "matchManagers": ["npm"],
       "matchUpdateTypes": ["minor", "patch", "major"]
     },
     {
       "branchTopic": "npm",
-      "commitMessageTopic": "npm",
       "matchDepTypes": ["dependencies"],
       "matchManagers": ["npm"],
       "matchUpdateTypes": ["minor", "patch", "major"]
@@ -77,7 +74,6 @@
     },
     {
       "branchTopic": "npm-lock",
-      "commitMessageTopic": "npm lockfile",
       "description": "Separate lockfile maintenance for npm",
       "groupName": "npm lockfile",
       "groupSlug": "npm-lockfile",
@@ -86,7 +82,6 @@
     },
     {
       "branchTopic": "pep621",
-      "commitMessageTopic": "pep621 lockfile",
       "description": "Separate lockfile maintenance for Python",
       "groupName": "python lockfile",
       "groupSlug": "python-lockfile",
diff --git a/test/mochaHooks.ts b/test/mochaHooks.ts
diff --git a/test/unit/.c8rc.json b/test/unit/.c8rc.json
diff --git a/test/unit/vitestSetup.ts b/test/unit/vitestSetup.ts
@@ -0,0 +1,2 @@
+import * as chai from "chai";
+chai.config.truncateThreshold = 0; // disable truncating
diff --git a/tools/test-setup.sh b/tools/test-setup.sh
@@ -70,7 +70,7 @@ fi
 
 if [[ "${OSTYPE:-}" == darwin* ]]; then
     # coreutils provides 'timeout' command
-    HOMEBREW_NO_ENV_HINTS=1 brew install -q libssh coreutils
+    HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_ENV_HINTS=1 brew install -q libssh coreutils
 fi
 
 is_podman_running() {
diff --git a/vitest.config.ts b/vitest.config.ts
@@ -0,0 +1,32 @@
+// used for unit tests from test/unit
+import { defineConfig } from "vitest/config";
+
+// see https://vitest.dev/guide/migration.html
+export default defineConfig({
+  test: {
+    globals: true,
+    silent: true,
+    include: ["test/unit/**/*.test.ts"],
+    exclude: ["test/unit/contentCreator/**"],
+    setupFiles: ["./test/unit/vitestSetup.ts"],
+    coverage: {
+      provider: "v8",
+      cleanOnRerun: true,
+      clean: true,
+      enabled: true,
+      reportsDirectory: "./out/coverage/unit",
+      reporter: ["cobertura", "lcovonly", "text", "text-summary"], // text-summary shows only overall coverage stats, skipping per-file details
+      include: ["src/**/**.{js,jsx,ts,tsx}"], // Include source files for coverage
+      exclude: [],
+      thresholds: {
+        branches: 8.45,
+      },
+    },
+    outputFile: {
+      junit: "./out/junit/unit/unit-test-results.xml",
+    },
+    reporters: ["default", "junit"],
+    testTimeout: 30003,
+    slowTestThreshold: 25000,
+  },
+});
diff --git a/yarn.lock b/yarn.lock
@@ -828,7 +828,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@eslint-community/eslint-utils@npm:^4.4.1, @eslint-community/eslint-utils@npm:^4.7.0, @eslint-community/eslint-utils@npm:^4.8.0":
+"@eslint-community/eslint-utils@npm:^4.7.0, @eslint-community/eslint-utils@npm:^4.8.0":
   version: 4.9.0
   resolution: "@eslint-community/eslint-utils@npm:4.9.0"
   dependencies:
@@ -3519,6 +3519,8 @@ __metadata:
     "@types/yargs": "npm:^17.0.35"
     "@typescript-eslint/parser": "npm:^8.48.0"
     "@vitejs/plugin-vue": "npm:^5.2.4"
+    "@vitest/coverage-v8": "npm:^4.0.14"
+    "@vitest/ui": "npm:^4.0.4"
     "@vscode-elements/elements": "npm:^2.0.0"
     "@vscode/test-cli": "npm:^0.0.12"
     "@vscode/test-electron": "npm:^2.5.2"
@@ -3532,7 +3534,6 @@ __metadata:
     eslint-formatter-gha: "npm:^1.6.0"
     eslint-formatter-unix: "npm:^9.0.1"
     eslint-plugin-chai-friendly: "npm:^1.1.0"
-    eslint-plugin-mocha: "npm:^11.2.0"
     eslint-plugin-prettier: "npm:^5.5.4"
     eslint-plugin-tsdoc: "npm:^0.5.0"
     express: "npm:^5.1.0"
@@ -3545,8 +3546,6 @@ __metadata:
     lodash: "npm:^4.17.21"
     marked: "npm:^17.0.1"
     minimatch: "npm:^10.1.1"
-    mocha: "npm:^11.7.5"
-    mocha-junit-reporter: "npm:^2.2.1"
     mocha-multi-reporters: "npm:^1.5.1"
     morgan: "npm:^1.10.1"
     npm-check-updates: "npm:^19.1.2"
@@ -3565,6 +3564,7 @@ __metadata:
     typescript-eslint: "npm:^8.48.0"
     uuid: "npm:^13.0.0"
     vite: "npm:^7.2.4"
+    vitest: "npm:^4.0.14"
     vscode-extension-tester: "npm:^8.19.0"
     vscode-languageclient: "npm:^9.0.1"
     vscode-uri: "npm:^3.1.0"
@@ -5372,18 +5372,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"eslint-plugin-mocha@npm:^11.2.0":
-  version: 11.2.0
-  resolution: "eslint-plugin-mocha@npm:11.2.0"
-  dependencies:
-    "@eslint-community/eslint-utils": "npm:^4.4.1"
-    globals: "npm:^15.14.0"
-  peerDependencies:
-    eslint: ">=9.0.0"
-  checksum: 10/7aebf15ed6c78a13167dd9ce3ab36a7cd5e964f167c88121ef64c86a2e2cc41bb37761bf88a66265cc252d0865f727cff4e7bf4106145850e403855b55a7fb71
-  languageName: node
-  linkType: hard
-
 "eslint-plugin-prettier@npm:^5.5.4":
   version: 5.5.4
   resolution: "eslint-plugin-prettier@npm:5.5.4"
@@ -6304,13 +6292,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"globals@npm:^15.14.0":
-  version: 15.15.0
-  resolution: "globals@npm:15.15.0"
-  checksum: 10/7f561c87b2fd381b27fc2db7df8a4ea7a9bb378667b8a7193e61fd2ca3a876479174e2a303a74345fbea6e1242e16db48915c1fd3bf35adcf4060a795b425e18
-  languageName: node
-  linkType: hard
-
 "globals@npm:^16.5.0":
   version: 16.5.0
   resolution: "globals@npm:16.5.0"

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "branches": 80.31,`
	`2`	`+ "branches": 81.24,`
`3`	`3`	`"check-coverage": true,`
`4`	`4`	`"extends": "../../.c8rc.json",`
`5`	`5`	`"lines": 0,`