Skip to content

Commit 5df9ede

Browse files
authored
fix: fix artifact paths in publish and publish-npm jobs (#2635)
## Summary Fixes two broken CI jobs that prevented releases from completing. ## Failures ### 1. `publish` job — `ls: cannot access 'out/*.vsix'` `download-artifact` without `path:` strips the `out/` prefix, so vsix files landed in workspace root instead of `out/`. Both `ls -la out/*.vsix` and `./tools/helper --publish` (which globs `out/ansible-*.vsix`) failed. Also fixes `files: "*.vsix"` → `files: "out/*.vsix"` in the GitHub release attachment step for consistency. ### 2. `publish-npm` job — Artifact not found The job requested artifact `@ansible-ansible-language-server-build-<id>.tgz` which was never uploaded. The `.tgz` is bundled inside the main artifact `ansible-extension-build-<id>.zip`. Fixed to download the correct artifact. ### 3. `publish-npm` job — `.github/actions/report` not found Missing checkout step caused the local report action to be unresolvable. Added `actions/checkout` before the report step. ## Changes - `publish`: add `path: out` to download step - `publish`: `files: "*.vsix"` → `files: "out/*.vsix"` - `publish-npm`: fix artifact name to use the main build artifact - `publish-npm`: add `path: out` to download step - `publish-npm`: fix npm publish glob to `out/@ansible-ansible-language-server-*.tgz` - `publish-npm`: add checkout step so `.github/actions/report` resolves
1 parent e6b9035 commit 5df9ede

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -587,13 +587,14 @@ jobs:
587587
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
588588
with:
589589
name: ansible-extension-build-${{ github.event.number || github.run_id }}.zip
590+
path: out
590591

591592
- name: Attach vsix to Github release
592593
# cspell: ignore softprops
593594
uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b # v2.5.0
594595
if: github.ref_type == 'tag'
595596
with:
596-
files: "*.vsix"
597+
files: "out/*.vsix"
597598

598599
- run: |
599600
yarn install --immutable
@@ -624,14 +625,18 @@ jobs:
624625
issues: write
625626
checks: read
626627
steps:
628+
- name: Checkout Source
629+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
630+
627631
- name: Download the artifact
628632
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
629633
with:
630-
name: "@ansible-ansible-language-server-build-${{ github.event.number || github.run_id }}.tgz"
634+
name: ansible-extension-build-${{ github.event.number || github.run_id }}.zip
635+
path: out
631636

632637
- uses: jdx/mise-action@6d1e696aa24c1aa1bcc1adea0212707c71ab78a8 # v3.6.1
633638

634-
- run: npm publish --access public @ansible-ansible-language-server-*.tgz
639+
- run: npm publish --access public out/@ansible-ansible-language-server-*.tgz
635640
env:
636641
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
637642

0 commit comments

Comments
 (0)