Remove 'Add Pattern' webview and jsonValidation (#2174)

* Remove add pattern webview and json validation

* Trigger RTD build again

* Update src/features/contentCreator/types.ts

Co-authored-by: Kate Case <[email protected]>

---------

Co-authored-by: Kate Case <[email protected]>

Author: alisonlhart

.sonarcloud.properties

@@ -15,13 +15,10 @@ sonar.cpd.exclusions=\
     src/webview/apps/contentCreator/createExecutionEnvPageApp.ts, \
     src/webview/apps/lightspeed/roleExplanation/main.ts, \
     src/features/lightspeed/vue/views/helloWorld.ts, \
-    webviews/AddPatternPageApp.vue,\
     src/features/contentCreator/vue/views/createExecutionEnvPanel.ts,\
     src/features/contentCreator/vue/views/createDevcontainerPanel.ts, \
-    webviews/add-pattern.ts, \
     src/features/contentCreator/vue/views/createDevfilePanel.ts, \
     webviews/CreateDevfileApp.vue, \
-    src/features/contentCreator/vue/views/addPatternPagePanel.ts, \
     src/features/contentCreator/vue/views/panelUtils.ts, \
     test/ui/*.ts, \
     test/unit/lightspeed/utils/handleApiError.test.ts, \

package.json

@@ -220,12 +220,6 @@
           "ansible-navigator.json"
         ],
         "url": "https://raw.githubusercontent.com/ansible/ansible-navigator/main/src/ansible_navigator/data/ansible-navigator.json"
-      },
-      {
-        "fileMatch": [
-          "patterns/*/meta/pattern.json"
-        ],
-        "url": "https://raw.githubusercontent.com/ansible/pattern-service/main/specifications/pattern-schema/pattern-schema-latest.json"
       }
     ],
     "yamlValidation": [
@@ -372,10 +366,6 @@
         "command": "ansible.content-creator.add-plugin",
         "title": "Ansible: Add a Plugin"
       },
-      {
-        "command": "ansible.content-creator.add-pattern",
-        "title": "Ansible: Add a Pattern"
-      },
       {
         "command": "ansible.content-creator.create-role",
         "title": "Ansible: Add Role"

src/extension.ts

@@ -82,7 +82,6 @@ import { MainPanel as ExplanationPanel } from "./features/lightspeed/vue/views/e
 import { MainPanel as HelloWorldPanel } from "./features/lightspeed/vue/views/helloWorld";
 import { MainPanel as createAnsibleCollectionPanel } from "./features/contentCreator/vue/views/createAnsibleCollectionPanel";
 import { MainPanel as createAnsibleProjectPanel } from "./features/contentCreator/vue/views/createAnsibleProjectPanel";
-import { MainPanel as addPatternPanel } from "./features/contentCreator/vue/views/addPatternPagePanel";
 import { MainPanel as addPluginPanel } from "./features/contentCreator/vue/views/addPluginPagePanel";
 import { MainPanel as createRolePanel } from "./features/contentCreator/vue/views/createRolePanel";
 import { MainPanel as createDevcontainerPanel } from "./features/contentCreator/vue/views/createDevcontainerPanel";
@@ -585,15 +584,6 @@ export async function activate(context: ExtensionContext): Promise<void> {
     ),
   );
 
-  context.subscriptions.push(
-    vscode.commands.registerCommand(
-      "ansible.content-creator.add-pattern",
-      () => {
-        addPatternPanel.render(context);
-      },
-    ),
-  );
-
   // open web-view for creating devfile
   context.subscriptions.push(
     vscode.commands.registerCommand(

src/features/contentCreator/types.ts

@@ -59,13 +59,6 @@ export type PluginFormInterface = {
   isOverwritten: boolean;
 };
 
-export type PatternFormInterface = {
-  patternName: string;
-  collectionPath: string;
-  verbosity: string;
-  isOverwritten: boolean;
-};
-
 export type RoleFormInterface = {
   roleName: string;
   collectionPath: string;

src/features/contentCreator/vue/views/addPatternPagePanel.ts

@@ -8,7 +8,6 @@ import {
   RoleFormInterface,
   PluginFormInterface,
   PostMessageEvent,
-  PatternFormInterface,
 } from "../../../contentCreator/types";
 import {
   getADEVersion,
@@ -33,101 +32,6 @@ export class AnsibleCreatorOperations {
     command = `ansible-creator add resource role ${roleName} ${url} --no-ansi`;
     return command;
   }
-  public async getPatternAddCommand(
-    patternName: string,
-    collectionPath: string,
-  ): Promise<string> {
-    let command = "";
-
-    command = `ansible-creator add resource pattern ${patternName} ${collectionPath} --no-ansi`;
-    return command;
-  }
-
-  public async runPatternAddCommand(
-    payload: PatternFormInterface,
-    webView: vscode.Webview,
-  ) {
-    const { patternName, collectionPath, isOverwritten, verbosity } = payload;
-
-    const destinationPathUrl =
-      collectionPath ||
-      `${os.homedir()}/.ansible/collections/ansible_collections`;
-
-    let ansibleCreatorAddCommand = await this.getPatternAddCommand(
-      patternName,
-      destinationPathUrl,
-    );
-
-    if (isOverwritten) {
-      ansibleCreatorAddCommand += " --overwrite";
-    } else {
-      ansibleCreatorAddCommand += " --no-overwrite";
-    }
-
-    const verbosityMap: Record<string, string> = {
-      off: "",
-      low: " -v",
-      medium: " -vv",
-      high: " -vvv",
-    };
-    const normalizedVerbosity = verbosity.toLowerCase();
-    const verbosityFlag = verbosityMap[normalizedVerbosity] || "";
-    ansibleCreatorAddCommand += verbosityFlag;
-
-    const extSettings = new SettingsManager();
-    await extSettings.initialize();
-
-    const { command, env } = withInterpreter(
-      extSettings.settings,
-      ansibleCreatorAddCommand,
-      "",
-    );
-
-    let commandOutput = "";
-    let commandResult: string;
-
-    const creatorVersion = await getCreatorVersion();
-    if (!creatorVersion || creatorVersion === "failed") {
-      commandOutput += `ansible-creator is not installed or not found in PATH.\n`;
-      commandOutput += `Please install ansible-creator and try again.\n`;
-      commandResult = "failed";
-      await webView.postMessage({
-        command: "execution-log",
-        arguments: {
-          commandOutput: commandOutput,
-          projectUrl: destinationPathUrl,
-          status: commandResult,
-        },
-      } as PostMessageEvent);
-      return;
-    }
-    const minRequiredCreatorVersion: Record<string, string> = {
-      role: "25.4.0",
-    };
-    const requiredCreatorVersion = minRequiredCreatorVersion["role"];
-
-    commandOutput += `----------------------------------------- ansible-creator logs ------------------------------------------\n`;
-
-    if (semver.gte(creatorVersion, requiredCreatorVersion)) {
-      const ansibleCreatorExecutionResult = await runCommand(command, env);
-      commandOutput += ansibleCreatorExecutionResult.output;
-      commandResult = ansibleCreatorExecutionResult.status;
-    } else {
-      commandOutput += `Minimum ansible-creator version needed to add the role resource is ${requiredCreatorVersion}\n`;
-      commandOutput += `The installed ansible-creator version on this system is ${creatorVersion}\n`;
-      commandOutput += `Please upgrade to the latest version of ansible-creator and try again.`;
-      commandResult = "failed";
-    }
-
-    await webView.postMessage({
-      command: "execution-log",
-      arguments: {
-        commandOutput: commandOutput,
-        projectUrl: destinationPathUrl,
-        status: commandResult,
-      },
-    } as PostMessageEvent);
-  }
 
   public async runRoleAddCommand(
     payload: RoleFormInterface,

src/features/lightspeed/vue/views/ansibleCreatorUtils.ts

@@ -115,14 +115,6 @@ export class FileOperations {
     this.openFileInEditor(parsedUrl.toString());
   }
 
-  public async openFolderInWorkspacePattern(
-    folderUrl: string,
-    patternName: string,
-  ) {
-    const patternFolderUrl = `${folderUrl}/extensions/patterns/${patternName}/playbooks/site.yml`;
-    await this.openFolderInWorkspaceCore(patternFolderUrl);
-  }
-
   public async openFolderInWorkspaceProjects(folderUrl: string) {
     await this.openFolderInWorkspaceCore(folderUrl);
 

src/features/lightspeed/vue/views/fileOperations.ts

@@ -23,7 +23,6 @@ import {
   AnsibleProjectFormInterface,
   RoleFormInterface,
   PluginFormInterface,
-  PatternFormInterface,
   DevcontainerFormInterface,
   DevfileFormInterface,
   AnsibleExecutionEnvInterface,
@@ -90,7 +89,6 @@ export class WebviewMessageHandlers {
       "init-create": this.handleInitCreate.bind(this),
       "init-create-plugin": this.handleInitCreatePlugin.bind(this),
       "init-create-role": this.handleInitCreateRole.bind(this),
-      "init-add-pattern": this.handleInitAddPattern.bind(this),
       "init-create-devcontainer": this.handleInitCreateDevcontainer.bind(this),
       "init-create-devfile": this.handleInitCreateDevfile.bind(this),
       "init-create-execution-env": this.handleInitCreateExecutionEnv.bind(this),
@@ -101,8 +99,6 @@ export class WebviewMessageHandlers {
       "init-open-log-file": this.handleInitOpenLogFile.bind(this),
       "init-open-scaffolded-folder":
         this.handleInitOpenScaffoldedFolder.bind(this),
-      "init-open-scaffolded-folder-pattern":
-        this.handleInitOpenScaffoldedFolderPattern.bind(this),
       "init-open-scaffolded-folder-plugin":
         this.handleInitOpenScaffoldedFolderPlugin.bind(this),
       "init-open-role-folder": this.handleInitOpenRoleFolder.bind(this),
@@ -242,10 +238,6 @@ export class WebviewMessageHandlers {
     const payload = message.payload as RoleFormInterface;
     await this.creatorOps.runRoleAddCommand(payload, webview);
   }
-  private async handleInitAddPattern(message: any, webview: vscode.Webview) {
-    const payload = message.payload as PatternFormInterface;
-    await this.creatorOps.runPatternAddCommand(payload, webview);
-  }
 
   private async handleInitCreateDevcontainer(
     message: any,
@@ -307,13 +299,6 @@ export class WebviewMessageHandlers {
       payload.pluginType,
     );
   }
-  private async handleInitOpenScaffoldedFolderPattern(message: any) {
-    const payload = message.payload;
-    await this.fileOps.openFolderInWorkspacePattern(
-      payload.projectUrl,
-      payload.patternName,
-    );
-  }
 
   private async handleInitOpenRoleFolder(message: any) {
     const payload = message.payload;