Migrate from yarn to pnpm

Author: ssbarnea

.config/dictionary.txt

@@ -299,5 +299,3 @@ xunit
 xvfb
 yaegassy
 yammlint
-yarnpkg
-yarnrc

.config/mise.toml

@@ -1,7 +1,7 @@
 [env]
 # https://github.com/nodejs/corepack/issues/550
 COREPACK_ENABLE_DOWNLOAD_PROMPT = 0
-# Command such `yarn webpack-dev` might fail with
+# Command such `pnpm webpack-dev` might fail with
 # Reached heap limit Allocation failed - JavaScript heap out of memory
 # https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes
 # default 16 MiB for 64-bit systems and 8 MiB for 32-bit systems
@@ -23,6 +23,6 @@ _.python.venv = {create = true, path = "~/.local/share/virtualenvs/vsa", python
 experimental = true
 
 [tools]
-# do not add tools unsupported on windows such: gh, yarn
+# do not add tools unsupported on windows such: gh
 direnv = "latest"
 node = "20.19.3"

.depcheckrc.yml

@@ -9,7 +9,7 @@
 # for build and testing purposes.
 export VIRTUAL_ENV="${HOME}/.local/share/virtualenvs/vsa"
 
-# Command such `yarn webpack-dev` might fail with
+# Command such `pnpm webpack-dev` might fail with
 # Reached heap limit Allocation failed - JavaScript heap out of memory
 # https://nodejs.org/api/cli.html#--max-old-space-sizesize-in-megabytes
 # default 16 MiB for 64-bit systems and 8 MiB for 32-bit systems

.envrc

@@ -152,31 +152,34 @@ jobs:
             xvfb
           # asdf nodejs plugin requires: dirmngr gpg curl gawk
 
-      - name: Setup node.js
+      - name: Install pnpm # keep before setup-node
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10
+          run_install: false
+
+      - name: Install node.js
         uses: actions/[email protected]
         with:
           node-version: 20
-          # yarn cache is broken due https://github.com/actions/setup-node/issues/531
-          # cache: yarn
+          cache: pnpm
 
-      - name: Corepack enable
-        run: corepack enable
+      - name: Install node dependencies
+        run: pnpm install
 
       - name: Enable caching
         uses: actions/cache@v4
         with:
           path: |
             .vscode-test
-            .yarn/cache
             node_modules/.cache/webpack
             out/ext
             out/test-resources*/Visual Studio Code.app
             out/test-resources*/chromedriver*
             out/test-resources*/driverVersion
             out/test-resources*/stable.zip
             ~/.cache/pip
-            ~/.cache/yarn
-          key: ${{ runner.os }}-${{ matrix.task-name }}-${{ hashFiles('package.json', 'yarn.lock', '.config/requirements.txt', 'tools/*.*') }}
+          key: ${{ runner.os }}-${{ matrix.task-name }}-${{ hashFiles('package.json', 'pnpm-lock.yaml', '.config/requirements.txt', 'tools/*.*') }}
 
       # - name: Enable caching for podman-machine
       #   if: "contains(matrix.os, 'macos')"
@@ -185,7 +188,7 @@ jobs:
       #     path: |
       #       ~/.local/share/containers
       #       ~/.config/containers
-      #     key: ${{ runner.os }}-${{ matrix.task-name }}-${{ hashFiles('package.json', 'yarn.lock', '.config/requirements.txt', '**/Taskfile.yml', 'tools/*.*') }}
+      #     key: ${{ runner.os }}-${{ matrix.task-name }}-${{ hashFiles('package.json', 'pnpm-lock.yaml', '.config/requirements.txt', '**/Taskfile.yml', 'tools/*.*') }}
 
       - name: Setup task
         uses: arduino/setup-task@v2
@@ -242,12 +245,6 @@ jobs:
           # Ensure NODE_OPTIONS config on CI is identical with the one in .env
           [[ "${NODE_OPTIONS:-}" == "$(direnv exec . printenv NODE_OPTIONS)" ]] || { echo "NODE_OPTIONS mismatch between .env and ci.yaml"; exit 97; }
 
-      - name: Install dependencies
-        uses: coactions/actions/yarn-install@fix/install
-        # backstage/actions/yarn-install@b3c1841fd69e1658ac631afafd0fb140a2309024 # v0.6.17
-        with:
-          cache-prefix: ${{ runner.os }}-v${{ matrix.node-version }}
-
       - name: task setup
         # starting podman machine can randomly get stuck on macos
         timeout-minutes: 25
@@ -515,8 +512,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          cache: yarn
-          cache-dependency-path: "**/yarn.lock"
+          cache: pnpm
           node-version-file: .tool-versions
 
       - name: Download the artifact
@@ -532,7 +528,7 @@ jobs:
           files: "*.vsix"
 
       - run: |
-          npm exec -- yarn install --immutable
+          npm exec -- pnpm install --immutable
           ls -la *.vsix
 
       - name: Setup python
@@ -563,8 +559,7 @@ jobs:
       # Setup .npmrc file to publish to npm
       - uses: actions/setup-node@v4
         with:
-          cache: yarn
-          cache-dependency-path: "**/yarn.lock"
+          cache: pnpm
           node-version-file: .tool-versions
           registry-url: "https://registry.npmjs.org"
 

.github/workflows/ci.yaml

@@ -11,13 +11,6 @@ CHANGELOG.html
 *.tgz
 .task
 .venv
-# https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
-.yarn/*
-!.yarn/patches
-!.yarn/plugins
-!.yarn/releases
-!.yarn/sdks
-!.yarn/versions
 .DS_Store
 .direnv
 coverage

.gitignore

@@ -1,7 +1,4 @@
 [allowlist]
 description = "Global Allowlist"
 # Ignore based on any subset of the file path
-paths = [
-  # Ignore yarn
-  '''\.yarn'''
-]
+paths = []

.gitleaks.toml

@@ -16,6 +16,7 @@ ci:
 exclude: >
   (?x)^(
     .config/requirements.in|
+    pnpm-lock.yaml|
     .*.svg
   )$
 minimum_pre_commit_version: 4.0.0 # Related to https://github.com/ekalinin/nodeenv/issues/369
@@ -54,12 +55,6 @@ repos:
           - SC1091
   - repo: local
     hooks:
-      - id: depcheck
-        name: depcheck
-        entry: yarn dlx depcheck
-        language: system
-        pass_filenames: false
-        always_run: true
       - id: eslint
         name: eslint
         entry: npm
@@ -118,7 +113,6 @@ repos:
       - id: trailing-whitespace
         exclude: >
           (?x)^(
-            .yarn/.*|
             examples/playbooks/(with-skip-tag-id|unicode).yml|
             examples/playbooks/example.yml|
             docs/als/settings.md

.pre-commit-config.yaml

@@ -38,13 +38,13 @@
 
   "files.exclude": {
     ".task": true,
-    ".yarn": true,
     ".vscode-test": true
   },
   "mochaExplorer.cwd": "packages/ansible-language-server",
   "search.exclude": {
     ".vscode-test": true
   },
   "redhat.telemetry.enabled": false,
-  "eslint.useESLintClass": true
+  "eslint.useESLintClass": true,
+  "npm.packageManager": "pnpm"
 }