Skip to content

Verify that tagged version and package version match before release #671

@germa89

Description

@germa89

So... yesterday I tried to do a "quick" release (disclaimer, it is never quick on PyMAPDL).

And I forgot to update the pyproject.toml to the new version (yeeeeahhh.. I know...), however the tag was correct. Hence I had tag with v0.69.2 and the pyproject.toml with v0.69.1.

Surprisingly, the CICD didn't fail, hence I didn't realise (thanks @greschd for letting me know).

Shouldn't the workflow fail? It is showing a warning though.

Image

One could argue that it is ok in case you want to attach new files after the release is done. Is this something we want to support??

Reference: https://github.com/ansys/pymapdl/actions/runs/12891417279/job/35962119607#step:3:994

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions