Skip to content

Commit 9c68b0a

Browse files
CHORE: Improve test efficiency (#6196)
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
1 parent 488380b commit 9c68b0a

22 files changed

Lines changed: 539 additions & 34796 deletions

.github/workflows/ci_cd.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -778,4 +778,4 @@ jobs:
778778
cname: ${{ env.DOCUMENTATION_CNAME }}
779779
token: ${{ secrets.GITHUB_TOKEN }}
780780
bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
781-
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
781+
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Improve test efficiency

src/ansys/aedt/core/generic/configurations.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1895,12 +1895,8 @@ def _get_duplicate_names(self):
18951895
# Copy project to get dictionary
18961896
from ansys.aedt.core.icepak import Icepak
18971897

1898-
directory = os.path.join(
1899-
self._app.toolkit_directory,
1900-
self._app.design_name,
1901-
generate_unique_folder_name("config_export_temp_project"),
1902-
)
1903-
os.makedirs(directory)
1898+
root_dir = os.path.join(self._app.toolkit_directory, self._app.design_name)
1899+
directory = generate_unique_folder_name(root_name=str(root_dir), folder_name="config_export_temp_project")
19041900
tempproj_name = os.path.join(directory, "temp_proj.aedt")
19051901
tempproj = Icepak(tempproj_name, version=self._app._aedt_version)
19061902
empty_design = tempproj.design_list[0]
@@ -1918,12 +1914,16 @@ def _get_duplicate_names(self):
19181914
tempproj.delete_design(empty_design)
19191915
tempproj.close_project()
19201916
dictionary = load_keyword_in_aedt_file(tempproj_name, "UserDefinedModels")["UserDefinedModels"]
1921-
for root, dirs, files in os.walk(directory, topdown=False):
1922-
for name in files:
1923-
os.remove(os.path.join(root, name))
1924-
for name in dirs:
1925-
os.rmdir(os.path.join(root, name))
1926-
os.rmdir(directory)
1917+
try:
1918+
for root, dirs, files in os.walk(directory, topdown=False):
1919+
for name in files:
1920+
os.remove(os.path.join(root, name))
1921+
for name in dirs:
1922+
os.rmdir(os.path.join(root, name))
1923+
os.rmdir(directory)
1924+
except Exception: # pragma: no cover
1925+
self._app.logger.error(f"An error occurred while removing {directory}.")
1926+
19271927
operation_dict = {"Source": {}, "Duplicate": {}}
19281928
list_dictionaries = []
19291929
for key in ["NativeComponentInstanceWithParams", "NativeComponentInstance", "UserDefinedModel"]:

src/ansys/aedt/core/modules/solve_setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1906,6 +1906,7 @@ def is_solved(self):
19061906
elif props.get(key, "HFSS") == "SIwaveDCIR":
19071907
expressions = self._app.post.available_report_quantities(solution=self.name, is_siwave_dc=True)
19081908
sol = self._app.post.reports_by_category.standard(expressions=expressions[0], setup=self.name)
1909+
sol.domain = "DCIR"
19091910
else:
19101911
expressions = [i for i in self._app.post.available_report_quantities(solution=self.name)]
19111912

-1.54 MB
Binary file not shown.

0 commit comments

Comments
 (0)