fix: Arguments in standalone launcher. #4656
Draft
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
hpohekar,
mayankansys,
mkundu1 and
seanpearsonuk
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing TLS-related arguments in the StandaloneLauncher class by adding certificates_folder and insecure_mode parameters to enable proper certificate configuration for Fluent's gRPC server.
- Added
certificates_folderparameter to specify TLS certificate location - Added
insecure_modeparameter to enable non-TLS gRPC connections
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| file_transfer_service: Any | None = None, | ||
| certificates_folder: str | None = None, | ||
| insecure_mode: bool = False, | ||
| ): |
There was a problem hiding this comment.
The newly added parameters certificates_folder and insecure_mode are not being used in the method body. They need to be stored or passed to the underlying implementation to have any effect.
Suggested change
| ): | |
| ): | |
| self.certificates_folder = certificates_folder | |
| self.insecure_mode = insecure_mode |
Contributor
|
Although these modes are not required for standalone launch, it is OK to add them as they are supported. Some user may look for a common script for different launch modes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
'certificates_folder' and 'insecure_mode' was missing in 'StandaloneLauncher'
Change Summary
'certificates_folder' and 'insecure_mode' were added as launcher args.
Impact
'certificates_folder' and 'insecure_mode' will be exposed.